Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

101 bug segmentation mask #123

Merged
merged 6 commits into from
Dec 10, 2023
Merged

101 bug segmentation mask #123

merged 6 commits into from
Dec 10, 2023

Conversation

okrusch
Copy link
Collaborator

@okrusch okrusch commented Dec 2, 2023

Description

The PR includes bug fixes and new models for the vision node.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Does this PR introduce a breaking change?

We now have a very good baseline by using the yolov8x-seg model.

Most important changes

vision_node.py was extended in functionality.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (might be obsolete with CI later on)
  • New and existing unit tests pass locally with my changes (might be obsolete with CI later on)

@okrusch okrusch requested a review from MaxJa4 December 2, 2023 08:53
@okrusch okrusch self-assigned this Dec 2, 2023
@okrusch okrusch linked an issue Dec 2, 2023 that may be closed by this pull request
Copy link

github-actions bot commented Dec 2, 2023

Simulation results

Metric Value
Avg. driving score 0.005892
Avg. route completion 0.02
Avg. infraction penalty 0.348058
Collisions with pedestrians 0.0
Collisions with vehicles 0.0
Collisions with layout 709.196
Red lights infractions 0.0
Stop sign infractions 0.0
Off-road infractions 0.001
Route deviations 0.0
Route timeouts 709.196
Agent blocked 0.0
Yield emergency vehicles infractions 0.0
Scenario timeouts 709.196
Min speed infractions 0.0

Copy link
Collaborator

@MaxJa4 MaxJa4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments on a few things.
The Linter of the CI is also failing.

Other than that, looks great. Looking forward to see the yolo model output live in the rviz window.


pass
output = self.model(cv_image)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passing half=True here switches to FP16 mode and saves VRAM + increases performance.
After that, maybe the preset=Low from the docker-compose file is obsolete after this.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can implement this on Monday. The YOLO-Models already run very fast.

@@ -21,7 +21,7 @@ services:

# based on https://github.com/ll7/paf21-1/blob/master/scenarios/docker-carla-sim-compose.yml
carla-simulator:
command: /bin/bash CarlaUE4.sh -quality-level=Epic -world-port=2000 -resx=800 -resy=600 -nosound
command: /bin/bash CarlaUE4.sh -quality-level=Low -world-port=2000 -resx=800 -resy=600 -nosound
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still necessary? I don't know how much that changes the visuals of the simulator and therefore influences the perception (e.g. small objects like traffic lights).

Copy link
Collaborator Author

@okrusch okrusch Dec 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will have to test it out with the new torch version. Low reduced the memory used by carla about 1.5GB. it might be an issues with far away objects. On close range It seems to be fine.

torch==1.13.1
torchvision==0.14.1
torchaudio==0.13.1
--extra-index-url https://download.pytorch.org/whl/cu117
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This conflicts with the new CUDA version introduced in #117 and shouldn't be part of this commit. Maybe also the three torch dependencies themselves, as all dependencies should have a frozen version.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will test it on the new torch version on Monday. We should be able to remove these changes.

Copy link

github-actions bot commented Dec 3, 2023

Simulation results

Metric Value
Avg. driving score 0.005892
Avg. route completion 0.02
Avg. infraction penalty 0.348058
Collisions with pedestrians 0.0
Collisions with vehicles 0.0
Collisions with layout 709.196
Red lights infractions 0.0
Stop sign infractions 0.0
Off-road infractions 0.001
Route deviations 0.0
Route timeouts 709.196
Agent blocked 0.0
Yield emergency vehicles infractions 0.0
Scenario timeouts 709.196
Min speed infractions 0.0

@okrusch okrusch requested a review from MaxJa4 December 7, 2023 11:48
Copy link

github-actions bot commented Dec 7, 2023

Simulation results

Metric Value
Avg. driving score 0.022873
Avg. route completion 0.18
Avg. infraction penalty 0.13471
Collisions with pedestrians 0.0
Collisions with vehicles 79.22
Collisions with layout 158.441
Red lights infractions 0.0
Stop sign infractions 0.0
Off-road infractions 0.011
Route deviations 0.0
Route timeouts 39.61
Agent blocked 39.61
Yield emergency vehicles infractions 0.0
Scenario timeouts 39.61
Min speed infractions 0.0

Copy link

github-actions bot commented Dec 7, 2023

Simulation results

Metric Value
Avg. driving score 0.009751
Avg. route completion 0.215
Avg. infraction penalty 0.245299
Collisions with pedestrians 0.0
Collisions with vehicles 68.962
Collisions with layout 137.923
Red lights infractions 0.0
Stop sign infractions 0.0
Off-road infractions 0.018
Route deviations 0.0
Route timeouts 68.962
Agent blocked 0.0
Yield emergency vehicles infractions 0.0
Scenario timeouts 34.481
Min speed infractions 0.0

@MaxJa4 MaxJa4 merged commit 12835bc into main Dec 10, 2023
3 checks passed
@MaxJa4 MaxJa4 deleted the 101-bug-segmentation-mask branch December 10, 2023 15:21
@coderabbitai coderabbitai bot mentioned this pull request Nov 10, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Segmentation Mask
2 participants