Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: package added with test code #133

Merged
merged 2 commits into from
Dec 7, 2023
Merged

feat: package added with test code #133

merged 2 commits into from
Dec 7, 2023

Conversation

samuelkuehnel
Copy link
Collaborator

Description

New package with test node CollisionCheck. In this package the local planning components will be stored. Documentation will be created when real features are added.
image

Fixes #132

Type of change

  • New feature (non-breaking change which adds functionality)

Does this PR introduce a breaking change?

no

Most important changes

new package in folder planning with all files necessary.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (might be obsolete with CI later on)
  • New and existing unit tests pass locally with my changes (might be obsolete with CI later on)

@samuelkuehnel samuelkuehnel added the infrastructure Docker, Project setup, ... label Dec 5, 2023
@samuelkuehnel samuelkuehnel self-assigned this Dec 5, 2023
@samuelkuehnel samuelkuehnel linked an issue Dec 5, 2023 that may be closed by this pull request
[Feature]: Create package for local planner #132
Closed
1 task
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2023

Simulation results

Metric Value
Avg. driving score 0.003617
Avg. route completion 0.015
Avg. infraction penalty 0.470558
Collisions with pedestrians 0.0
Collisions with vehicles 0.0
Collisions with layout 496.532
Red lights infractions 0.0
Stop sign infractions 0.0
Off-road infractions 0.001
Route deviations 0.0
Route timeouts 993.065
Agent blocked 0.0
Yield emergency vehicles infractions 0.0
Scenario timeouts 993.065
Min speed infractions 0.0

JuliusMiller
JuliusMiller suggested changes Dec 6, 2023
View reviewed changes
Copy link
Collaborator

@JuliusMiller JuliusMiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See local_planner.launch file.
Is this unnecessary code ?

code/planning/local_planner/launch/local_planner.launch Outdated
@@ -0,0 +1,14 @@
<launch>
<!--
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is copied from global_planner and can be removed ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes the comment can be deleted. I will clear this out.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment is removed

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2023

Simulation results

Metric Value
Avg. driving score 0.058844
Avg. route completion 0.28
Avg. infraction penalty 0.330352
Collisions with pedestrians 0.0
Collisions with vehicles 26.505
Collisions with layout 79.515
Red lights infractions 0.0
Stop sign infractions 0.0
Off-road infractions 0.007
Route deviations 0.0
Route timeouts 26.505
Agent blocked 26.505
Yield emergency vehicles infractions 0.0
Scenario timeouts 26.505
Min speed infractions 0.0

JuliusMiller
JuliusMiller approved these changes Dec 7, 2023
View reviewed changes
Copy link
Collaborator

@JuliusMiller JuliusMiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Change. Good Work!

@JuliusMiller JuliusMiller merged commit 3961862 into main Dec 7, 2023
3 checks passed
@JuliusMiller JuliusMiller deleted the 132-feature-create-package-for-local-planner branch December 7, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuliusMiller JuliusMiller JuliusMiller approved these changes

Assignees

@samuelkuehnel samuelkuehnel

Labels
infrastructure Docker, Project setup, ...
Projects
PAF Project Backlog
Archived in project
Milestone
Average Driving Score of 0.10
Development

Successfully merging this pull request may close these issues.

[Feature]: Create package for local planner
2 participants
@samuelkuehnel @JuliusMiller