Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

152 - Traffic light detection improvements #161

Merged
merged 5 commits into from
Jan 30, 2024

Conversation

MaxJa4
Copy link
Collaborator

@MaxJa4 MaxJa4 commented Jan 13, 2024

Description

More robust traffic light detection, better handling of side-facing traffic lights, support for different kinds of intersections (due to placement of traffic lights).

Fixes #152

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Does this PR introduce a breaking change?

No

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes (might be obsolete with CI later on)

@MaxJa4 MaxJa4 added enhancement New feature or request perception labels Jan 13, 2024
@MaxJa4 MaxJa4 requested a review from okrusch January 13, 2024 17:45
@MaxJa4 MaxJa4 self-assigned this Jan 13, 2024
Copy link

Simulation results

Metric Value
Avg. driving score 0.09338
Avg. route completion 1.575
Avg. infraction penalty 0.112656
Collisions with pedestrians 0.0
Collisions with vehicles 36.105
Collisions with layout 13.539
Red lights infractions 0.0
Stop sign infractions 4.513
Off-road infractions 0.009
Route deviations 9.026
Route timeouts 0.0
Agent blocked 0.0
Yield emergency vehicles infractions 0.0
Scenario timeouts 4.513
Min speed infractions 0.0

@samuelkuehnel samuelkuehnel self-requested a review January 30, 2024 10:57
Copy link
Collaborator

@samuelkuehnel samuelkuehnel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As Leon is ill, i will perform the review.
Nice improvements, looking forward to test them out!!!!!!!!!!!!!!

@MaxJa4 MaxJa4 merged commit 869f0e1 into main Jan 30, 2024
3 checks passed
@MaxJa4 MaxJa4 deleted the 152-feat-traffic-light-detection-improvements branch January 30, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request perception
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Feature]: Traffic Light Detection improvements
2 participants