Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

166 bug lag when emergency braking in leaderboard eval #174

Merged

Conversation

robertik10
Copy link
Collaborator

Description

The Simulation started to lag really badly in the Leaderboard version whenever we started an emergency brake.
Now this issue is fixed and we can emergency brake without problems!

Fixes #166

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Does this PR introduce a breaking change?

makes emergency brakes work!

Most important changes

acting -> vehicle_controller.py
Especially the way the emergency brake was implemented and how its embedded in the loop now

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (might be obsolete with CI later on)
  • New and existing unit tests pass locally with my changes (might be obsolete with CI later on)

@robertik10 robertik10 self-assigned this Jan 26, 2024
@robertik10 robertik10 linked an issue Jan 26, 2024 that may be closed by this pull request
Copy link
Collaborator

@samuelkuehnel samuelkuehnel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fixes for emergency brake!

@samuelkuehnel samuelkuehnel merged commit 26aab61 into main Jan 29, 2024
2 of 3 checks passed
@samuelkuehnel samuelkuehnel deleted the 166-bug-lag-when-emergency-braking-in-leaderboard-eval branch January 30, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Lag when emergency braking in leaderboard eval
2 participants