Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

197 feature dimensions of objects #198

Merged
merged 19 commits into from
Mar 9, 2024

Conversation

okrusch
Copy link
Collaborator

@okrusch okrusch commented Mar 6, 2024

Description

The PR enhances the capability of the vision node. We now publish the upper_right and lower_left corner of a bounding box as 3D-World coordinates.

Fixes # (197)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Does this PR introduce a breaking change?

Described above

Most important changes

vision node

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (might be obsolete with CI later on)
  • New and existing unit tests pass locally with my changes (might be obsolete with CI later on)

@okrusch okrusch requested a review from samuelkuehnel March 6, 2024 12:48
@okrusch okrusch self-assigned this Mar 6, 2024
@okrusch okrusch linked an issue Mar 6, 2024 that may be closed by this pull request
ll7 added 3 commits March 7, 2024 08:40
Update build.yml by removing sudo rm disk space
prune images from self-hosted runner
Copy link

github-actions bot commented Mar 7, 2024

Simulation results

Metric Value
Avg. driving score 0.0504
Avg. route completion 0.155
Avg. infraction penalty 0.3465
Collisions with pedestrians 0.0
Collisions with vehicles 85.081
Collisions with layout 42.54
Red lights infractions 0.0
Stop sign infractions 0.0
Off-road infractions 0
Route deviations 0.0
Route timeouts 85.081
Agent blocked 0.0
Yield emergency vehicles infractions 0.0
Scenario timeouts 85.081
Min speed infractions 0.0

Copy link
Collaborator

@samuelkuehnel samuelkuehnel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very Helpful changes. Further adjusting of vision node outputs where done on the branch 192

@samuelkuehnel samuelkuehnel merged commit 908d383 into main Mar 9, 2024
3 checks passed
@samuelkuehnel samuelkuehnel deleted the 197-feature-dimensions-of-objects branch March 9, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Feature]: Dimensions of Objects
3 participants