Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: hotfixing steering for leaderboard #217

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

hellschwalex
Copy link
Collaborator

@hellschwalex hellschwalex commented Mar 14, 2024

Description

Since all Tuning, Testing etc for Acting (Steering in particular) was done in dev.launch with perfect Sensors, the very well tuned PurePursuit Controller would be expected to outperform in the leaderboard-enviroment aswell. This is NOT the case (and we do not know why exactly).
Bringing back Stanley Controller (with a new, softer tuning to regard Sensor-Flickering) for velocities of 6+ m/s and retuning PurePursuit Controllers amplification factor (from 4.75 to under 1, again to regard Sensor-Flickering) should highly increase driving score.
Again I do not exactly know, why the well-tested and goodworking tuning from dev.launch does not work in the leaderboard. So this is a rather "dirty" hotfix (but it works).

Fixes #216 (issue)

Type of change

  • PurePursuit amplification factor retuned for leaderboard
  • Stanley is back, retuned for leaderboard

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (might be obsolete with CI later on)
  • New and existing unit tests pass locally with my changes (might be obsolete with CI later on)

@hellschwalex hellschwalex self-assigned this Mar 14, 2024
@hellschwalex hellschwalex linked an issue Mar 14, 2024 that may be closed by this pull request
Copy link

Simulation results

Metric Value
Avg. driving score 0.19351
Avg. route completion 8.01
Avg. infraction penalty 0.02413
Collisions with pedestrians 1.691
Collisions with vehicles 7.609
Collisions with layout 0.845
Red lights infractions 0.0
Stop sign infractions 0.0
Off-road infractions 0
Route deviations 0.0
Route timeouts 0.0
Agent blocked 1.691
Yield emergency vehicles infractions 0.0
Scenario timeouts 2.536
Min speed infractions 0.0

Copy link
Collaborator

@robertik10 robertik10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be working!

@robertik10 robertik10 merged commit f1aa502 into main Mar 14, 2024
3 checks passed
@samuelkuehnel samuelkuehnel deleted the 216-feature-hotfix-steering branch April 1, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Feature]: Hotfix steering
2 participants