383 fix type hints that are not compatible with python 3.8

[niklasr22]

Description

With #418 I used a not yet compatible version of type hinting. This reverts the mistake.

Type of change

Please delete options that are not relevant.

• Bug fix

Summary by CodeRabbit

• Chores
  • Enhanced method signature clarity with type hinting for better code readability.
  • Added import statement for List from the typing module.

[coderabbitai]

Walkthrough

The changes involve updating the type hinting for the __calc_corner_points method in the MotionPlanning class within the motion_planning.py file. The return type has been modified from list[list[np.ndarray]] to List[List[np.ndarray]], and an import statement for List from the typing module has been added at the top of the file. These modifications clarify the method's signature without altering any logic or control flow.

Changes

File Path	Change Summary
code/planning/src/local_planner/motion_planning.py	Updated return type of __calc_corner_points method from list[list[np.ndarray]] to List[List[np.ndarray]] and added import for List from typing.

Poem

In the planner's code, oh what a sight,
Types now clearer, shining bright!
With lists of lists, they dance and play,
A hint of type, to guide the way.
Hoppy changes, a joyful cheer,
For clarity's sake, we hold so dear! 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 6b37448 and 50f3821.

📒 Files selected for processing (1)

• code/planning/src/local_planner/motion_planning.py (2 hunks)

🔇 Additional comments (3)

code/planning/src/local_planner/motion_planning.py (3)

6-6: LGTM! Required import for Python 3.8 compatibility.

The addition of from typing import List is correct and necessary for using generic type hints in Python 3.8.

---

333-333: LGTM! Fixed type hint for Python 3.8 compatibility.

The return type hint has been correctly updated from list[list[np.ndarray]] to List[List[np.ndarray]] to maintain compatibility with Python 3.8.

---

Line range hint 1-728: Verify other type hints in the file.

I notice several other type hints in the file. Let's verify if they also need updates for Python 3.8 compatibility.

✅ Verification successful

No type hint issues found in the file

The type hints in the file are already compatible with Python 3.8. The file:

• Uses the typing module correctly by importing List from it
• Uses proper type annotations for class attributes (e.g., velocity_sub: Subscriber)
• Uses proper return type hints with the -> syntax (e.g., def __calc_corner_points(self) -> List[List[np.ndarray]])
• Does not use any built-in types directly in type hints that would need to be replaced with their typing module equivalents

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Search for potential type hint issues in the file
# Look for built-in type hints that need to be replaced with typing module equivalents

# Search for type hints using built-in types (list, dict, tuple, etc.)
echo "Searching for type hints using built-in types..."
rg -U "def [^(]+\([^)]*\)\s*->\s*(list|dict|tuple|set)\[" code/planning/src/local_planner/motion_planning.py

# Search for variable annotations using built-in types
echo "Searching for variable annotations using built-in types..."
rg -U ":\s*(list|dict|tuple|set)\[" code/planning/src/local_planner/motion_planning.py

Length of output: 433

---

Script:

#!/bin/bash
# Let's search for all type hints in the file to get a complete picture
echo "Searching for all type hints and annotations..."
rg -U "def [^(]+\([^)]*\)\s*->\s*\w+.*:|:\s*\w+.*=|#\s*type:\s+" code/planning/src/local_planner/motion_planning.py

# Also search specifically for typing module usage
echo "Searching for typing module usage..."
rg -U "from typing import|List|Dict|Tuple|Set|Optional|Union|Any|Callable" code/planning/src/local_planner/motion_planning.py

Length of output: 7398

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.