Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add link to videos of the runs #481

Merged
merged 2 commits into from
Nov 20, 2024
Merged

add link to videos of the runs #481

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e7de5fc
add link to videos of the runs
seitzseb Nov 10, 2024
499f617
Merge branch 'main' into 480-add-google-doc-link-to-screencasts-in-th…
vinzenzm Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions doc/research/paf24/general/current_state.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,8 @@ Here are the raw notes in case misunderstandings have been made when grouping th

### Run 1

[Link to Video of the Run](https://drive.google.com/file/d/1Hb4arEC5ocfUD2KZh1bNVwRG2hoML8E9/view?usp=drive_link)

Comment on lines +131 to +132
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Videos should be stored in a more reliable location with documented backup strategy

The verification reveals that:

  • The video files are only referenced in current_state.md with Google Drive links
  • There are no local video files in the repository
  • No documentation exists regarding video storage guidelines or backup strategies

To ensure long-term accessibility of these important simulation results:

  • Store videos in a more permanent location (e.g., team's asset management system)
  • Add textual descriptions of key observations from each video
  • Document the video storage location and backup strategy in the repository
  • Consider including compressed screenshots for quick reference
🔗 Analysis chain

Consider improving video link reliability and accessibility.

While adding video documentation is valuable, consider:

  1. Verify that the Google Drive links have proper sharing permissions set
  2. Consider adding alternative hosting or local copies for redundancy
  3. Document the expected video content in case links become inaccessible

Also applies to: 158-159, 175-176

Let me generate one more verification to check if there's any documentation about video storage guidelines or if videos are stored anywhere else in the repository.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check if videos are referenced elsewhere in the codebase
# and if there's a backup location defined

# Search for any other references to these video files
rg -i "1Hb4arEC5ocfUD2KZh1bNVwRG2hoML8E9|1xot90LTNcSYOkLa1sXJJeMFBkXKmFO2x|1ERvN3nGddzuvtRqtIF2PKlFrcMzH2MrA"

# Check for potential backup documentation
fd -t f "backup" -X grep -l "video"

Length of output: 619

Script:

#!/bin/bash
# Check for documentation about video storage or guidelines
rg -i "video.*storage|storage.*video|video.*guideline|media.*storage|storage.*media" -g "*.md"

# Check if there are any video files in the repository
fd -e mp4 -e avi -e mov -e mkv

# Check for any documentation about media assets
fd -t f "media" -X grep -l "video\|storage\|backup"

Length of output: 181

- Scared to get out of parking spot
- lane not held causing problems when avoiding open car door
- stopping for no apparent reason
Expand All @@ -153,6 +155,8 @@ Here are the raw notes in case misunderstandings have been made when grouping th

### Run 2

[Link to Video of the Run](https://drive.google.com/file/d/1xot90LTNcSYOkLa1sXJJeMFBkXKmFO2x/view?usp=drive_link)

- merges without giving way to traffic
- does not respect open car door
- crashes into car in front when going after stop at red light
Expand All @@ -168,6 +172,8 @@ Here are the raw notes in case misunderstandings have been made when grouping th

### Run 3

[Link to Video of the Run](https://drive.google.com/file/d/1ERvN3nGddzuvtRqtIF2PKlFrcMzH2MrA/view?usp=drive_link)

- does not give way when exiting a parking spot
- LIDAR detects floor
- trajectory for overtaking is wrong / no overtake needed
Expand Down
Loading