Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed permissions for project folders #50

Merged

Conversation

JulianTrommer
Copy link
Member

@JulianTrommer JulianTrommer commented Nov 14, 2023

Description

The permissions of all folders besides the folder code now allow the files to be edited.

Fixes #49

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Does this PR introduce a breaking change?

No

Most important changes

See changed file.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (might be obsolete with CI later on)
  • New and existing unit tests pass locally with my changes (might be obsolete with CI later on)

@JulianTrommer JulianTrommer added the bug Something isn't working label Nov 14, 2023
@JulianTrommer JulianTrommer requested a review from ll7 November 14, 2023 12:10
@JulianTrommer JulianTrommer self-assigned this Nov 14, 2023
@JulianTrommer JulianTrommer linked an issue Nov 14, 2023 that may be closed by this pull request
@ll7
Copy link
Member

ll7 commented Nov 14, 2023

#38 could also be fixed by this change?

@JulianTrommer JulianTrommer merged commit 11429d6 into main Nov 14, 2023
2 checks passed
@JulianTrommer JulianTrommer deleted the 49-bug-file-permissions-of-folders-too-restrictive branch November 14, 2023 12:25
Copy link

Simulation results

Metric Value
Avg. driving score 0.00015
Avg. route completion 11.375
Avg. infraction penalty 1.4e-05
Collisions with pedestrians 1.4e-05
Collisions with vehicles 0.606
Collisions with layout 20.002
Red lights infractions 2.425
Stop sign infractions 1.212
Off-road infractions 2.425
Route deviations 0.355
Route timeouts 0.0
Agent blocked 0.606
Yield emergency vehicles infractions 0.606
Scenario timeouts 0.0
Min speed infractions 1.818
undefined 0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: File permissions of folders too restrictive
2 participants