Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature-shape2d-polygon-class-for-intermediate-layer-and-cluster-integration #616
feature-shape2d-polygon-class-for-intermediate-layer-and-cluster-integration #616
Changes from 4 commits
ed2521f
ccc37d4
40633c3
6e1bc22
95e5037
feb7ce1
521b3f1
f71ad13
ab62362
06f8779
a45e4cb
d175c32
cf11cd5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix documentation and complete the implementation.
The function has several issues:
entity_id
andframe_id
are documented but not used)Polygon
frommapping.ext_modules.mapping_common.shape
shapely_polygon
Apply this diff to fix the issues:
🧰 Tools
🪛 Ruff (0.8.2)
416-416: Local variable
shapely_polygon
is assigned to but never usedRemove assignment to unused variable
shapely_polygon
(F841)