Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] #64 - Add ability to specify map in Dataset-Generator #65

Merged
merged 2 commits into from
Nov 20, 2023

Conversation

MaxJa4
Copy link
Collaborator

@MaxJa4 MaxJa4 commented Nov 16, 2023

Description

Adds the ability to specify map in Dataset-Generator.
Also doesn't force a world-reload when using without use_empty_world so it can be used with a running evaluation scenario - like anticipated as stated in the docs.

Fixes #64

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Does this PR introduce a breaking change?

No

Most important changes

Specifying the desired map.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (might be obsolete with CI later on)
  • New and existing unit tests pass locally with my changes (might be obsolete with CI later on)

@MaxJa4 MaxJa4 added the enhancement New feature or request label Nov 16, 2023
@MaxJa4 MaxJa4 self-assigned this Nov 16, 2023
@MaxJa4 MaxJa4 requested a review from okrusch November 16, 2023 18:42

This comment was marked as off-topic.

@MaxJa4 MaxJa4 requested review from samuelkuehnel and removed request for okrusch November 18, 2023 15:48
Copy link
Collaborator

@samuelkuehnel samuelkuehnel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple, helpful and documented 👍

@MaxJa4 MaxJa4 merged commit e844735 into main Nov 20, 2023
3 checks passed
@MaxJa4 MaxJa4 deleted the 64-Specify-map-for-dataset_generator branch November 20, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Feature]: Ability to specify the map for DatasetGenerator
2 participants