Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

86 new segmentation node #98

Merged
merged 4 commits into from
Nov 27, 2023
Merged

86 new segmentation node #98

merged 4 commits into from
Nov 27, 2023

Conversation

okrusch
Copy link
Collaborator

@okrusch okrusch commented Nov 26, 2023

Description

I build a new rosnode that uses object-detection and image-segmentation.

Fixes # (86)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Does this PR introduce a breaking change?

We have a new running node in the perception

Most important changes

Running VisionNode.
Visualisation of model output in Rviz.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (might be obsolete with CI later on)
  • New and existing unit tests pass locally with my changes (might be obsolete with CI later on)

@okrusch okrusch requested a review from MaxJa4 November 26, 2023 10:10
Copy link

Simulation results

Metric Value
Avg. driving score 0.01456
Avg. route completion 0.05
Avg. infraction penalty 0.364
Collisions with pedestrians 0.364
Collisions with vehicles 0.0
Collisions with layout 146.027
Red lights infractions 292.055
Stop sign infractions 0.0
Off-road infractions 0.0
Route deviations 0
Route timeouts 0.0
Agent blocked 292.055
Yield emergency vehicles infractions 0.0
Scenario timeouts 0.0
Min speed infractions 292.055
undefined 0.0

Copy link
Collaborator

@MaxJa4 MaxJa4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall.
Looking forward to see it "live" with close to real-time performance when CUDA works.
Maybe adding FP16 mode helps with the OOM issue. CUDA not working might be due to old/wrong cuda/torch versions in the image or locally.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The linter fails in the docs file.

Copy link

Simulation results

Metric Value
Avg. driving score 0.006941
Avg. route completion 0.11
Avg. infraction penalty 0.249718
Collisions with pedestrians 0.249718
Collisions with vehicles 0.0
Collisions with layout 134.193
Red lights infractions 201.29
Stop sign infractions 0.0
Off-road infractions 0.0
Route deviations 0.01
Route timeouts 0.0
Agent blocked 134.193
Yield emergency vehicles infractions 0.0
Scenario timeouts 0.0
Min speed infractions 67.097
undefined 0.0

Copy link

Simulation results

Metric Value
Avg. driving score 0.010465
Avg. route completion 0.035
Avg. infraction penalty 0.364
Collisions with pedestrians 0.364
Collisions with vehicles 0.0
Collisions with layout 206.865
Red lights infractions 413.731
Stop sign infractions 0.0
Off-road infractions 0.0
Route deviations 0
Route timeouts 0.0
Agent blocked 413.731
Yield emergency vehicles infractions 0.0
Scenario timeouts 0.0
Min speed infractions 413.731
undefined 0.0

@okrusch okrusch merged commit 090cbc4 into main Nov 27, 2023
3 checks passed
@MaxJa4 MaxJa4 deleted the 86-new-segmentation-node branch November 28, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants