Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify estimated label text #1615

Merged
merged 2 commits into from
Jan 4, 2024
Merged

Conversation

KJhellico
Copy link
Collaborator

Proposed change

Now estimated holidays look like "Eid al-Fitr* (*estimated)". Usually this style is used for footnotes at the end of text or page. In our case, the explanation goes directly after the text. Therefore, I propose to remove the asterisk (similar to the label for observed holidays) - "Eid al-Fitr (estimated)".

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

@KJhellico KJhellico requested a review from arkid15r as a code owner December 30, 2023 16:31
@coveralls
Copy link

coveralls commented Dec 30, 2023

Pull Request Test Coverage Report for Build 7379476727

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 7379327874: 0.0%
Covered Lines: 10299
Relevant Lines: 10299

💛 - Coveralls

Copy link

sonarqubecloud bot commented Jan 1, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

11 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 LGMT

@arkid15r arkid15r added this pull request to the merge queue Jan 4, 2024
Merged via the queue into vacanza:beta with commit 154181d Jan 4, 2024
26 checks passed
@KJhellico KJhellico deleted the ref-estimated-label branch January 4, 2024 17:06
@arkid15r arkid15r mentioned this pull request Jan 5, 2024
10 tasks
@arkid15r arkid15r mentioned this pull request Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants