-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build and push Docker vitess/vttestserver
DockerHub from GitHub Actions
#14314
Merged
frouioui
merged 2 commits into
vitessio:main
from
planetscale:docker-build-vttestserver
Oct 19, 2023
Merged
Build and push Docker vitess/vttestserver
DockerHub from GitHub Actions
#14314
frouioui
merged 2 commits into
vitessio:main
from
planetscale:docker-build-vttestserver
Oct 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florent Poinsard <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Oct 19, 2023
frouioui
added
Type: CI/Build
Component: Docker
and removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
labels
Oct 19, 2023
Signed-off-by: Florent Poinsard <[email protected]>
frouioui
requested review from
deepthi,
mattlord and
rohit-nayak-ps
as code owners
October 19, 2023 18:26
deepthi
approved these changes
Oct 19, 2023
mattlord
approved these changes
Oct 19, 2023
4 tasks
frouioui
added a commit
that referenced
this pull request
Nov 13, 2023
…ions (#14314) Signed-off-by: Florent Poinsard <[email protected]>
frouioui
added a commit
to planetscale/vitess
that referenced
this pull request
Nov 13, 2023
…ions (vitessio#14314) Signed-off-by: Florent Poinsard <[email protected]>
frouioui
added a commit
to planetscale/vitess
that referenced
this pull request
Nov 13, 2023
…ions (vitessio#14314) Signed-off-by: Florent Poinsard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
vitess/vttestserver
to the list of images that are going to be built by GitHub Actions rather than by DockerHub.Example runs of this workflow are available on my fork:
main
mysql80
tag on DockerHubmysql57
tag on DockerHubv99.99.9-mysql57
tag on DockerHubv99.99.9-mysql80
tag on DockerHubRelated Issue(s)
Checklist
Deployment Notes