-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vtexplain
and vtbackup
to base docker auto-build
#14318
Merged
frouioui
merged 2 commits into
vitessio:main
from
planetscale:add-vtexplain-vtbackup-to-base-build
Oct 20, 2023
Merged
Add vtexplain
and vtbackup
to base docker auto-build
#14318
frouioui
merged 2 commits into
vitessio:main
from
planetscale:add-vtexplain-vtbackup-to-base-build
Oct 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florent Poinsard <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Oct 19, 2023
Signed-off-by: Florent Poinsard <[email protected]>
frouioui
requested review from
deepthi,
mattlord and
rohit-nayak-ps
as code owners
October 19, 2023 19:34
frouioui
added
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
Type: CI/Build
Component: Docker
and removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
labels
Oct 19, 2023
frouioui
added
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
and removed
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
labels
Oct 19, 2023
deepthi
approved these changes
Oct 19, 2023
mattlord
approved these changes
Oct 20, 2023
frouioui
added a commit
that referenced
this pull request
Nov 13, 2023
Signed-off-by: Florent Poinsard <[email protected]>
frouioui
added a commit
to planetscale/vitess
that referenced
this pull request
Nov 13, 2023
) Signed-off-by: Florent Poinsard <[email protected]>
frouioui
added a commit
to planetscale/vitess
that referenced
this pull request
Nov 13, 2023
) Signed-off-by: Florent Poinsard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component: Docker
Type: CI/Build
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the
vtexplain
andvtbackup
images to the list of images we autobuild on push tomain
and on new tags.Testing workflow on my own fork: https://github.com/frouioui/vitess/actions/runs/6579148743
vtbackup
on my DockerHub: linkvtexplain
on my DockerHub: linkI opened #14316 earlier to remove
vtbackup
entirely, but then ended up thinking keeping it and building as part of the already-existing process would be better.Related Issue(s)
Checklist
Deployment Notes