Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade the Golang Dependencies #15743

Merged
merged 10 commits into from
Apr 22, 2024
Merged

Upgrade the Golang Dependencies #15743

merged 10 commits into from
Apr 22, 2024

Conversation

vitess-bot
Copy link
Contributor

This Pull Request updates all the Golang dependencies to their latest version using go get -u ./....

cc @vitessio/release

Signed-off-by: GitHub <[email protected]>
@vitess-bot vitess-bot added Component: General Changes throughout the code base dependencies Pull requests that update a dependency file go labels Apr 17, 2024
@vitess-bot vitess-bot requested a review from ajm188 as a code owner April 17, 2024 18:15
@vitess-bot vitess-bot requested a review from a team April 17, 2024 18:15
Copy link
Contributor

vitess-bot bot commented Apr 17, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Apr 17, 2024
@frouioui frouioui removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Apr 17, 2024
@github-actions github-actions bot added this to the v20.0.0 milestone Apr 17, 2024
This change means "opening" a connection no longer really already dials
to the actual other side, so we should see if this has any other
significant effects if we instead dial on first request.

The old stuff is deprecated though, so we have to bite the bullet at
some point. Alternatively, we essentially copy this initial connect
logic into our side instead.

Signed-off-by: Dirkjan Bussink <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
@frouioui frouioui marked this pull request as draft April 17, 2024 21:48
@frouioui
Copy link
Member

The test TestLifeCycle is failing consistently when initializing the zookeeper deamon. I am unable to reproduce the error on my machine or on a remote machine. Using CI to debug the issue.

2024-04-17T21:35:35.0975488Z === RUN   TestLifeCycle
2024-04-17T21:35:35.0975782Z E0417 21:26:35.521474   59338 zkctl.go:195] failed starting, check /tmp/zk_255/logs
2024-04-17T21:35:35.0976123Z     zkctl_test.go:49: Init() err: dial tcp :2181: connect: connection refused
2024-04-17T21:35:35.0976281Z --- FAIL: TestLifeCycle (30.01s)

Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
@frouioui frouioui marked this pull request as ready for review April 18, 2024 01:03
@frouioui
Copy link
Member

The errors in Ci will be fixed via #15757.

Copy link

codecov bot commented Apr 22, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 68.48%. Comparing base (c1bddd7) to head (a4c728e).
Report is 1 commits behind head on main.

Files Patch % Lines
go/vt/vtgate/fakerpcvtgateconn/conn.go 0.00% 1 Missing ⚠️
go/vtbench/client.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15743      +/-   ##
==========================================
+ Coverage   68.40%   68.48%   +0.07%     
==========================================
  Files        1556     1556              
  Lines      195425   195756     +331     
==========================================
+ Hits       133678   134056     +378     
+ Misses      61747    61700      -47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Florent Poinsard <[email protected]>
@frouioui frouioui merged commit a89b2cb into main Apr 22, 2024
203 checks passed
@frouioui frouioui deleted the upgrade-go-deps-on-main-test branch April 22, 2024 21:25
@dbussink
Copy link
Contributor

The change in a4c728e is not correct I think. The deprecation GRPC did in 1.63.0 was undone and is going to happen in the next release. But we can't then just put back grpc.Dial, we also then need to revert the other changes that cleaned up context usage.

@dbussink dbussink mentioned this pull request Apr 23, 2024
5 tasks
@dbussink
Copy link
Contributor

#15780 reverts the context change bits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: General Changes throughout the code base dependencies Pull requests that update a dependency file go Type: Internal Cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants