-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade the Golang Dependencies #15743
Conversation
Signed-off-by: GitHub <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
This change means "opening" a connection no longer really already dials to the actual other side, so we should see if this has any other significant effects if we instead dial on first request. The old stuff is deprecated though, so we have to bite the bullet at some point. Alternatively, we essentially copy this initial connect logic into our side instead. Signed-off-by: Dirkjan Bussink <[email protected]> Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
The test
|
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
The errors in Ci will be fixed via #15757. |
…in-test Signed-off-by: Florent Poinsard <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15743 +/- ##
==========================================
+ Coverage 68.40% 68.48% +0.07%
==========================================
Files 1556 1556
Lines 195425 195756 +331
==========================================
+ Hits 133678 134056 +378
+ Misses 61747 61700 -47 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Florent Poinsard <[email protected]>
The change in a4c728e is not correct I think. The deprecation GRPC did in 1.63.0 was undone and is going to happen in the next release. But we can't then just put back |
#15780 reverts the context change bits. |
This Pull Request updates all the Golang dependencies to their latest version using
go get -u ./...
.cc @vitessio/release