Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link to filtered tables from alert event sources #2735

Merged
merged 6 commits into from
Sep 15, 2022
Merged

Link to filtered tables from alert event sources #2735

merged 6 commits into from
Sep 15, 2022

Conversation

joshri
Copy link
Contributor

@joshri joshri commented Sep 13, 2022

Closes #2734

What changed?

@joshri joshri added the area/ui Issues that require front-end work label Sep 13, 2022
@ozamosi
Copy link
Contributor

ozamosi commented Sep 14, 2022

Sweet!

Just, I think this is missing filtering on kind.

@joshri
Copy link
Contributor Author

joshri commented Sep 14, 2022

Sweet!

Just, I think this is missing filtering on kind.

Oops...in taking out the * conditional I just...deleted the whole thing. Fixing.

@joshri joshri marked this pull request as ready for review September 14, 2022 12:49
ozamosi
ozamosi approved these changes Sep 14, 2022
View reviewed changes
Copy link
Contributor

@ozamosi ozamosi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Limitations: if you click on an event source that has no matches, then you get an empty list of matches (as expected), but you also don't get the chips you should (which isn't expected). This seems unrelated to this change, though.

@joshri
Copy link
Contributor Author

joshri commented Sep 14, 2022

Limitations: if you click on an event source that has no matches, then you get an empty list of matches (as expected), but you also don't get the chips you should (which isn't expected). This seems unrelated to this change, though.

Maybe we need a something other than "No data" in the data table...a small message like the new notifications and dependencies have?

@joshri joshri force-pushed the event-source-link branch 2 times, most recently from de20f11 to 4c62e03 Compare September 14, 2022 16:37
opudrovs
opudrovs reviewed Sep 14, 2022
View reviewed changes
ui/components/__tests__/AlertsTable.test.tsx Outdated
expect(
sourceLink.includes("type") && sourceLink.includes("GitRepository")
).toEqual(true);
console.log(sourceLink);
Copy link
Contributor

@opudrovs opudrovs Sep 14, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great test!

The only question: does this call to console.log have any special purpose?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UGH. I'm fired. Thanks for finding that

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

side-whispering Great that I cover my tracks well. Since some totally random time I always search in files for console.log and fmt.Println before submitting my PRs for review. 🤣

@joshri joshri merged commit 0913c5a into main Sep 15, 2022
@joshri joshri deleted the event-source-link branch September 15, 2022 13:17
@weave-gitops-bot weave-gitops-bot mentioned this pull request Sep 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@opudrovs opudrovs opudrovs approved these changes

@ozamosi ozamosi ozamosi approved these changes

Assignees
No one assigned
Labels
area/ui Issues that require front-end work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Alert event sources should be represented by links
3 participants
@joshri @ozamosi @opudrovs