Skip to content

General fix for MSPI drivers and Apollo3p mspi feature update #162657

General fix for MSPI drivers and Apollo3p mspi feature update

General fix for MSPI drivers and Apollo3p mspi feature update #162657

Triggered via pull request November 26, 2024 11:23
Status Success
Total duration 2m 37s
Artifacts 1

compliance.yml

on: pull_request
Run compliance checks on patch series (PR)
2m 29s
Run compliance checks on patch series (PR)
Fit to window
Zoom out
Zoom in

Annotations

1 error, 1 warning, and 10 notices
Run compliance checks on patch series (PR)
Process completed with exit code 1.
Run compliance checks on patch series (PR): ClangFormat.txt#L1
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#clang-format for more details. You may want to run clang-format on this change: - data->trans.rx_dummy = data->dev_cfg.rx_dummy; + data->trans.rx_dummy = data->dev_cfg.rx_dummy; File:drivers/flash/flash_mspi_atxp032.c Line:128 You may want to run clang-format on this change: - data->trans.tx_dummy = data->dev_cfg.tx_dummy; + data->trans.tx_dummy = data->dev_cfg.tx_dummy; File:drivers/flash/flash_mspi_atxp032.c Line:160 You may want to run clang-format on this change: - data->trans.rx_dummy = data->dev_cfg.rx_dummy; + data->trans.rx_dummy = data->dev_cfg.rx_dummy; data->trans.cmd_length = data->dev_cfg.cmd_length; data->trans.addr_length = data->dev_cfg.addr_length; data->trans.hold_ce = false; - data->trans.priority = MSPI_XFER_PRIORITY_MEDIUM; + data->trans.priority = MSPI_XFER_PRIORITY_MEDIUM; File:drivers/flash/flash_mspi_atxp032.c Line:336 You may want to run clang-format on this change: - data->trans.tx_dummy = data->dev_cfg.tx_dummy; + data->trans.tx_dummy = data->dev_cfg.tx_dummy; data->trans.rx_dummy = data->dev_cfg.rx_dummy; data->trans.cmd_length = data->dev_cfg.cmd_length; data->trans.addr_length = data->dev_cfg.addr_length; data->trans.hold_ce = false; - data->trans.priority = MSPI_XFER_PRIORITY_MEDIUM; + data->trans.priority = MSPI_XFER_PRIORITY_MEDIUM; File:drivers/flash/flash_mspi_atxp032.c Line:419 You may want to run clang-format on this change: - data->trans.tx_dummy = data->dev_cfg.tx_dummy; + data->trans.tx_dummy = data->dev_cfg.tx_dummy; data->trans.rx_dummy = 8; data->trans.cmd_length = 1; data->trans.addr_length = 3; data->trans.hold_ce = false; - data->trans.priority = MSPI_XFER_PRIORITY_MEDIUM; + data->trans.priority = MSPI_XFER_PRIORITY_MEDIUM; File:drivers/flash/flash_mspi_atxp032.c Line:737 You may want to run clang-format on this change: -#define MSPI_TIMING_CONFIG(n) \ +#define MSPI_TIMING_CONFIG(n) \ COND_CODE_1(CONFIG_SOC_FAMILY_AMBIQ, \ - (MSPI_AMBIQ_TIMING_CONFIG(n)), ({})) \ - -#define MSPI_TIMING_CONFIG_MASK(n) \ + (MSPI_AMBIQ_TIMING_CONFIG(n)), ({})) + +#define MSPI_TIMING_CONFIG_MASK(n) \ COND_CODE_1(CONFIG_SOC_FAMILY_AMBIQ, \ - (MSPI_AMBIQ_TIMING_CONFIG_MASK(n)), (MSPI_TIMING_PARAM_DUMMY)) \ - -#define MSPI_PORT(n) \ - COND_CODE_1(CONFIG_SOC_FAMILY_AMBIQ, \ - (MSPI_AMBIQ_PORT(n)), (0)) \ + (MSPI_AMBIQ_TIMING_CONFIG_MASK(n)), (MSPI_TIMING_PARAM_DUMMY)) + +#define MSPI_PORT(n) COND_CODE_1(CONFIG_SOC_FAMILY_AMBIQ, \ + (MSPI_AMBIQ_PORT(n)), (0)) File:drivers/flash/flash_mspi_atxp032.c Line:831 You may want to run clang-format on this change: - data->xfer.priority = MSPI_XFER_PRIORITY_MEDIUM; + data->xfer.priority = MSPI_XFER_PRIORITY_MEDIUM; File:drivers/flash/flash_mspi_emul_device.c Line:219 You may want to run clang-format on this change: - data->xfer.priority = MSPI_XFER_PRIORITY_MEDIUM; + data->xfer.priority = MSPI_XFER_PRIORITY_MEDIUM; File:drivers/flash/flash_mspi_emul_device.c Line:292 You may want to run clang-format on this change: - data->trans.rx_dummy = data->dev_cfg.rx_dummy; + data->trans.rx_dummy = data->dev_cfg.rx_dummy; File:drivers/memc/memc_mspi_aps6404l.c Line:86 You may want to run clang-form
You may want to run clang-format on this change: drivers/flash/flash_mspi_atxp032.c#L128
drivers/flash/flash_mspi_atxp032.c:128 - data->trans.rx_dummy = data->dev_cfg.rx_dummy; + data->trans.rx_dummy = data->dev_cfg.rx_dummy;
You may want to run clang-format on this change: drivers/flash/flash_mspi_atxp032.c#L160
drivers/flash/flash_mspi_atxp032.c:160 - data->trans.tx_dummy = data->dev_cfg.tx_dummy; + data->trans.tx_dummy = data->dev_cfg.tx_dummy;
You may want to run clang-format on this change: drivers/flash/flash_mspi_atxp032.c#L336
drivers/flash/flash_mspi_atxp032.c:336 - data->trans.rx_dummy = data->dev_cfg.rx_dummy; + data->trans.rx_dummy = data->dev_cfg.rx_dummy; data->trans.cmd_length = data->dev_cfg.cmd_length; data->trans.addr_length = data->dev_cfg.addr_length; data->trans.hold_ce = false; - data->trans.priority = MSPI_XFER_PRIORITY_MEDIUM; + data->trans.priority = MSPI_XFER_PRIORITY_MEDIUM;
You may want to run clang-format on this change: drivers/flash/flash_mspi_atxp032.c#L419
drivers/flash/flash_mspi_atxp032.c:419 - data->trans.tx_dummy = data->dev_cfg.tx_dummy; + data->trans.tx_dummy = data->dev_cfg.tx_dummy; data->trans.rx_dummy = data->dev_cfg.rx_dummy; data->trans.cmd_length = data->dev_cfg.cmd_length; data->trans.addr_length = data->dev_cfg.addr_length; data->trans.hold_ce = false; - data->trans.priority = MSPI_XFER_PRIORITY_MEDIUM; + data->trans.priority = MSPI_XFER_PRIORITY_MEDIUM;
You may want to run clang-format on this change: drivers/flash/flash_mspi_atxp032.c#L737
drivers/flash/flash_mspi_atxp032.c:737 - data->trans.tx_dummy = data->dev_cfg.tx_dummy; + data->trans.tx_dummy = data->dev_cfg.tx_dummy; data->trans.rx_dummy = 8; data->trans.cmd_length = 1; data->trans.addr_length = 3; data->trans.hold_ce = false; - data->trans.priority = MSPI_XFER_PRIORITY_MEDIUM; + data->trans.priority = MSPI_XFER_PRIORITY_MEDIUM;
You may want to run clang-format on this change: drivers/flash/flash_mspi_atxp032.c#L831
drivers/flash/flash_mspi_atxp032.c:831 -#define MSPI_TIMING_CONFIG(n) \ +#define MSPI_TIMING_CONFIG(n) \ COND_CODE_1(CONFIG_SOC_FAMILY_AMBIQ, \ - (MSPI_AMBIQ_TIMING_CONFIG(n)), ({})) \ - -#define MSPI_TIMING_CONFIG_MASK(n) \ + (MSPI_AMBIQ_TIMING_CONFIG(n)), ({})) + +#define MSPI_TIMING_CONFIG_MASK(n) \ COND_CODE_1(CONFIG_SOC_FAMILY_AMBIQ, \ - (MSPI_AMBIQ_TIMING_CONFIG_MASK(n)), (MSPI_TIMING_PARAM_DUMMY)) \ - -#define MSPI_PORT(n) \ - COND_CODE_1(CONFIG_SOC_FAMILY_AMBIQ, \ - (MSPI_AMBIQ_PORT(n)), (0)) \ + (MSPI_AMBIQ_TIMING_CONFIG_MASK(n)), (MSPI_TIMING_PARAM_DUMMY)) + +#define MSPI_PORT(n) COND_CODE_1(CONFIG_SOC_FAMILY_AMBIQ, \ + (MSPI_AMBIQ_PORT(n)), (0))
You may want to run clang-format on this change: drivers/flash/flash_mspi_emul_device.c#L219
drivers/flash/flash_mspi_emul_device.c:219 - data->xfer.priority = MSPI_XFER_PRIORITY_MEDIUM; + data->xfer.priority = MSPI_XFER_PRIORITY_MEDIUM;
You may want to run clang-format on this change: drivers/flash/flash_mspi_emul_device.c#L292
drivers/flash/flash_mspi_emul_device.c:292 - data->xfer.priority = MSPI_XFER_PRIORITY_MEDIUM; + data->xfer.priority = MSPI_XFER_PRIORITY_MEDIUM;
You may want to run clang-format on this change: drivers/memc/memc_mspi_aps6404l.c#L86
drivers/memc/memc_mspi_aps6404l.c:86 - data->trans.rx_dummy = data->dev_cfg.rx_dummy; + data->trans.rx_dummy = data->dev_cfg.rx_dummy;
You may want to run clang-format on this change: drivers/memc/memc_mspi_aps6404l.c#L123
drivers/memc/memc_mspi_aps6404l.c:123 - data->trans.tx_dummy = data->dev_cfg.tx_dummy; + data->trans.tx_dummy = data->dev_cfg.tx_dummy;

Artifacts

Produced during runtime
Name Size
compliance.xml
6.56 KB