Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Periph to compile with !AP_GPS_ENABLED #25119

Merged
merged 5 commits into from
Oct 4, 2023

Conversation

peterbarker
Copy link
Contributor

No description provided.

@peterbarker peterbarker force-pushed the pr/AP_Periph_compile_no_AP_GPS branch from a3aef8d to 95f3060 Compare September 27, 2023 07:50
@peterbarker peterbarker force-pushed the pr/AP_Periph_compile_no_AP_GPS branch 2 times, most recently from d43b575 to 5cb0416 Compare October 4, 2023 00:36
@peterbarker peterbarker force-pushed the pr/AP_Periph_compile_no_AP_GPS branch from 5cb0416 to 747589c Compare October 4, 2023 00:39
@peterbarker peterbarker force-pushed the pr/AP_Periph_compile_no_AP_GPS branch from 747589c to 48bc344 Compare October 4, 2023 00:40
@peterbarker
Copy link
Contributor Author

I've run this through size-compare-branches.py and it's all-stars except Durandal (due to some optimisation things in AP_AHRS.cpp), and HerePro which now gets AP_AHRS_ENABLED.

HerePro has scripting enabled, that has methods in it into the Location library which require AP_AHRS - so we need to compile the AP_AHRS library in. It will still die if it ever calls the AHRS methods as we won't be instating the singleton.

Can't use PH's new per-method depends as it doesn't seem to work on userdata things.

Closes potential problem with HerePro if it calls AP_AHRS methods
@peterbarker
Copy link
Contributor Author

... added a patch that creates the AHRS singleton if AP_AHRS_ENABLED is true, which would stop HerePro from dying if you were to call AHRS methods on it.

CubeOrange-Periph-heavy got 880 bytes smaller as it doesn't include scripting and thus no AHRS is required.

@tridge tridge merged commit 748dd22 into ArduPilot:master Oct 4, 2023
86 checks passed
@IamPete1 IamPete1 removed the DevCallEU label Oct 4, 2023
@peterbarker peterbarker deleted the pr/AP_Periph_compile_no_AP_GPS branch October 4, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants