Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hwdef: added files for Airvolute DCS2 onboard FMU #25354

Merged
merged 2 commits into from
Dec 12, 2023

Conversation

vrsanskytom
Copy link
Contributor

@vrsanskytom vrsanskytom commented Oct 24, 2023

  • added hwdef files for Airvolute DCS2 onboard FMU

Current state:
-Bl: working
-FW: running, possible to connect through MAVLINK and onboard USB connection

@andyp1per andyp1per force-pushed the hwdef_for_airvolute_dcs2 branch 2 times, most recently from 5ac9018 to 9a3fd7a Compare October 26, 2023 19:56
@khancyr khancyr added the hwdef label Nov 1, 2023
@vrsanskytom
Copy link
Contributor Author

Added some default parameters. Device tested and all of the features works properly.

@vrsanskytom vrsanskytom force-pushed the hwdef_for_airvolute_dcs2 branch from d702dd9 to c879be4 Compare November 28, 2023 13:36
@andyp1per andyp1per force-pushed the hwdef_for_airvolute_dcs2 branch from c879be4 to b399146 Compare December 1, 2023 10:11
@Ryanf55
Copy link
Collaborator

Ryanf55 commented Dec 4, 2023

MacOS failures are unrelated. I performed a rebase.

@Ryanf55 Ryanf55 force-pushed the hwdef_for_airvolute_dcs2 branch from b399146 to 0e5fab2 Compare December 4, 2023 23:04
- SERIAL0 -> USB
- SERIAL1 -> UART2 (Telem1)
- SERIAL2 -> UART3 (Telem2)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it only have 3 UARTs?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and one used as RC....

@tridge tridge requested a review from Hwurzburg December 4, 2023 23:40
@tridge
Copy link
Contributor

tridge commented Dec 4, 2023

marked for doc review by Henry - needs pinout information in the README

@Hwurzburg
Copy link
Collaborator

@vrsanskytom can you send me the wiring diagram so I can review? I will need that and a pinout list for the board to review for wiki page...and other suggestions, like default protocols,etc.

@vrsanskytom
Copy link
Contributor Author

@Hwurzburg OK, we will update wiki today and try to make it containing everything important.

@Hwurzburg
Copy link
Collaborator

Hwurzburg commented Dec 5, 2023

making a wiki page like : https://ardupilot.org/copter/docs/common-holybro-pixhawk6X.html is certainly appreciated, but I usually make that page based off the README.md file here. Its important that it be accurate and complete not only to assist in the wiki page production, but also as a code document for other developer's reference. I check the README.md versus the hwdef for consistency and completeness, and check the wiring diagram and pinouts like a user to be sure nothing is confusing...for example, you specify UART3 as the only RC input but do not default its protocol to RCin which would be expected by a user (also since its only RX pinned out,it wont support RC like CRSF,ELRS, or SRXL2)...

FYI I usually dont create a wik page for autopilots that will not be offered commercially as a standalone.During the DevCal I had asked if this autopilot would be offered for sale and Tridge had said he thought it would, but the hwdef does not build this firmware, so users could not upgrade the firmware...so will it be offered for standalone?if so, that hwdef line should be removed

@vrsanskytom
Copy link
Contributor Author

@Hwurzburg We just updated the readme, now it should contain all of the important information.

I`m not sure if I understand properly what does it mean to remove hwdef line. But the whole board definitely is offered commercially, and we would like users to have the possibility to upgrade the firmware (firmware updates are handled from companion computer).

Copy link
Collaborator

@Hwurzburg Hwurzburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few suggested changes after full reveiw

also needs squash, rebase, and split using Tools/gittools/git-subsystems-split

libraries/AP_HAL_ChibiOS/hwdef/Airvolute-DCS2/README.md Outdated Show resolved Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/Airvolute-DCS2/README.md Outdated Show resolved Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/Airvolute-DCS2/README.md Outdated Show resolved Hide resolved
@vrsanskytom
Copy link
Contributor Author

vrsanskytom commented Dec 8, 2023

Thanks for review. We will do what necessary.

@vrsanskytom vrsanskytom force-pushed the hwdef_for_airvolute_dcs2 branch 2 times, most recently from ec130cf to c5cde62 Compare December 8, 2023 10:53
added ethernet config to hwdef
updated readme.md
hwdef: MAC parameters redefined according to ChibiOS
hwdef: add default params for Airvolute DCS2 on board FMU
update according to new changes in ChibiOS MAC driver
added defines to support ethernet communication
bootloaders: Airvolute-DCS2
added ethernet config to hwdef
updated readme.md
hwdef: MAC parameters redefined according to ChibiOS
hwdef: add default params for Airvolute DCS2 on board FMU
update according to new changes in ChibiOS MAC driver
added defines to support ethernet communication
bootloaders: Airvolute-DCS2
@vrsanskytom vrsanskytom force-pushed the hwdef_for_airvolute_dcs2 branch from c5cde62 to fae8c20 Compare December 8, 2023 11:24
@vrsanskytom
Copy link
Contributor Author

Should be ready to merge. Thanks

@Hwurzburg Hwurzburg added DevCallTopic WikiNeeded needs wiki update labels Dec 8, 2023
@vrsanskytom vrsanskytom requested a review from Ryanf55 December 10, 2023 07:27
@tridge tridge merged commit 3dd27b7 into ArduPilot:master Dec 12, 2023
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hwdef WikiNeeded needs wiki update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants