-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hwdef: added files for Airvolute DCS2 onboard FMU #25354
hwdef: added files for Airvolute DCS2 onboard FMU #25354
Conversation
5ac9018
to
9a3fd7a
Compare
Added some default parameters. Device tested and all of the features works properly. |
d702dd9
to
c879be4
Compare
c879be4
to
b399146
Compare
MacOS failures are unrelated. I performed a rebase. |
b399146
to
0e5fab2
Compare
- SERIAL0 -> USB | ||
- SERIAL1 -> UART2 (Telem1) | ||
- SERIAL2 -> UART3 (Telem2) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it only have 3 UARTs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and one used as RC....
marked for doc review by Henry - needs pinout information in the README |
@vrsanskytom can you send me the wiring diagram so I can review? I will need that and a pinout list for the board to review for wiki page...and other suggestions, like default protocols,etc. |
@Hwurzburg OK, we will update wiki today and try to make it containing everything important. |
making a wiki page like : https://ardupilot.org/copter/docs/common-holybro-pixhawk6X.html is certainly appreciated, but I usually make that page based off the README.md file here. Its important that it be accurate and complete not only to assist in the wiki page production, but also as a code document for other developer's reference. I check the README.md versus the hwdef for consistency and completeness, and check the wiring diagram and pinouts like a user to be sure nothing is confusing...for example, you specify UART3 as the only RC input but do not default its protocol to RCin which would be expected by a user (also since its only RX pinned out,it wont support RC like CRSF,ELRS, or SRXL2)... FYI I usually dont create a wik page for autopilots that will not be offered commercially as a standalone.During the DevCal I had asked if this autopilot would be offered for sale and Tridge had said he thought it would, but the hwdef does not build this firmware, so users could not upgrade the firmware...so will it be offered for standalone?if so, that hwdef line should be removed |
@Hwurzburg We just updated the readme, now it should contain all of the important information. I`m not sure if I understand properly what does it mean to remove hwdef line. But the whole board definitely is offered commercially, and we would like users to have the possibility to upgrade the firmware (firmware updates are handled from companion computer). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few suggested changes after full reveiw
also needs squash, rebase, and split using Tools/gittools/git-subsystems-split
Thanks for review. We will do what necessary. |
ec130cf
to
c5cde62
Compare
added ethernet config to hwdef updated readme.md hwdef: MAC parameters redefined according to ChibiOS hwdef: add default params for Airvolute DCS2 on board FMU update according to new changes in ChibiOS MAC driver added defines to support ethernet communication bootloaders: Airvolute-DCS2
added ethernet config to hwdef updated readme.md hwdef: MAC parameters redefined according to ChibiOS hwdef: add default params for Airvolute DCS2 on board FMU update according to new changes in ChibiOS MAC driver added defines to support ethernet communication bootloaders: Airvolute-DCS2
c5cde62
to
fae8c20
Compare
Should be ready to merge. Thanks |
Current state:
-Bl: working
-FW: running, possible to connect through MAVLINK and onboard USB connection