Add support for deca frame in QuadPlane::setup #27874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tridge
approved these changes
Aug 21, 2024
|
@IdoBuchman got a photo of the plane? |
|
needs commit msg fixing, thanks to @peterbarker for volunteering! |
The deca frame is properly supported for Copter and as the quadplane vtol setup calls upon the copter frames, it should also be supported for arduplane vtol for anyone who wants to work 10 vertical motors.
peterbarker
force-pushed
the
bugfix/quadplane-deca-support
branch
from
c692365 to
3f77417
Compare
|
Fixed the commit message, marked as MergeOnCIPass. Thanks! |
|
@tridge Still designing the plane, wanted to make sure 10 vertical motors will be supported before I build it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue #27846 .
Looking at the full parameter list for Plane, Q_Frame_Class = 14 (Deca) is a valid option and going over the AP_MotorsMatrix, Deca seems to be supported for types 'Plus' and 'X'.
However when I configure my AP's frame class to be Deca, I get messages saying "Config Error: fix problem then reboot" and "Config Error: Unsupported Q_Frame_Class 14".
The deca frame is properly supported for Copter and as the quadplane vtol setup calls upon the copter frames, it should also be supported for arduplane vtol for anyone who wants to work 10 vertical motors.