Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tradheli: fix yaw attitude error corrections while rotors turning on the ground #28690

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

bnsgeyer
Copy link
Contributor

This PR addresses an issue with the handling of yaw attitude error corrections being fed to the rate controller when the aircraft is on the ground with rotors turning. Currently the yaw attitude error correction is being fed to the rate controller with both integrator management schemes. This PR keeps the heading error correction when using the leaky integrator but removes it when using the integrator management that triggers on the landing detector.

This also cleans up some inconsistencies in the logic with landed and pretakeoff althold states in each of the non-manual throttle flight modes.

It also addresses the definition of behaviors for Spool up/down which was not addressed at all in the manual throttle modes. The only one that affects copter is Drift

Needs testing.

@MattKear
Copy link
Contributor

@bnsgeyer why not apply this to the leaky I case as well? I appreciate it is arguably not needed, but there is also no harm in applying it, as far as I can tell. By not applying it would reduce the amount of checks in the if statements and make the code easier to read.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants