Tradheli: fix yaw attitude error corrections while rotors turning on the ground #28690
+40
−31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue with the handling of yaw attitude error corrections being fed to the rate controller when the aircraft is on the ground with rotors turning. Currently the yaw attitude error correction is being fed to the rate controller with both integrator management schemes. This PR keeps the heading error correction when using the leaky integrator but removes it when using the integrator management that triggers on the landing detector.
This also cleans up some inconsistencies in the logic with landed and pretakeoff althold states in each of the non-manual throttle flight modes.
It also addresses the definition of behaviors for Spool up/down which was not addressed at all in the manual throttle modes. The only one that affects copter is Drift
Needs testing.