-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect orthogonal lines using RANSAC #1314
Open
julianschuler
wants to merge
11
commits into
HULKs:main
Choose a base branch
from
julianschuler:in-the-corner
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianschuler
force-pushed
the
in-the-corner
branch
4 times, most recently
from
July 19, 2024 07:22
de0a1d2
to
cf101c5
Compare
julianschuler
changed the title
Detect corners using RANSAC
Detect orthogonal lines using RANSAC
Jul 19, 2024
julianschuler
force-pushed
the
in-the-corner
branch
from
July 31, 2024 14:19
cf101c5
to
181f222
Compare
einmal mit kalibrierter Kamera testen |
julianschuler
force-pushed
the
in-the-corner
branch
from
December 4, 2024 15:00
181f222
to
5219fe5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why? What?
This PR implements detecting orthogonal lines in the field using RANSAC. This improves the placement of line segments near corners.
Depends on #1334.
ToDo / Known Issues
ransac_iterations
should be increased.Ideas for Next Iterations (Not This PR)
How to Test
Enable recording and upload to a NAO. Watch the replay and have a look at the image panel with the line detection overlay enabled. The green lines show the fitted orthogonal lines, the red ones the fitted lines. Note that only the blue lines are the extracted line segments used for localization.