Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove snowflake conversion immunities #3477

Merged

Conversation

RikuTheKiller
Copy link
Contributor

@RikuTheKiller RikuTheKiller commented Sep 19, 2024

About The Pull Request

Removes the hardcoded snowflake check that security can't be converted by a blood brother.
Also adds a balloon alert for if you get a second flash. It might be obscured by the flash somewhat but it's better than nothing.

And finally, removes IPC flash protection from conversion by head revs and blood brothers. No, it's not perfect, yes, it's snowflakey, but it's the best I could do without losing my sanity and it's better than nothing.

Why It's Good For The Game

They have mindshields for a fucking reason damnit.
If you go out of your way to remove it, it's fair game.

Also, IPCs sticking around revs has been a long standing issue.
You technically aren't allowed to kill them. But they can just ambush you.
It's bullshit gameplay and shouldn't exist at all ever.

Changelog

🆑
balance: Blood Brothers can now convert members of security if their mindshields are removed.
balance: IPCs are no longer immune to being converted by revolutionaries and blood brothers.
qol: You now get a balloon alert if you get a second flash as a Blood Brother.
/:cl:

@RikuTheKiller RikuTheKiller changed the title Removes a snowflake bb check for security Remove snowflake conversion checks Sep 19, 2024
@RikuTheKiller RikuTheKiller changed the title Remove snowflake conversion checks Remove snowflake conversion immunities (by adding more snowflake behaviour lol) Sep 19, 2024
@RikuTheKiller RikuTheKiller marked this pull request as draft September 19, 2024 21:12
@RikuTheKiller RikuTheKiller force-pushed the no_stupid_snowflake_shit branch from f2ef15e to ef03144 Compare September 19, 2024 21:15
@RikuTheKiller RikuTheKiller changed the title Remove snowflake conversion immunities (by adding more snowflake behaviour lol) Remove snowflake conversion immunities Sep 19, 2024
@RikuTheKiller RikuTheKiller marked this pull request as ready for review September 19, 2024 21:39
@Absolucy Absolucy merged commit 16f2f99 into Monkestation:master Sep 28, 2024
24 checks passed
@Absolucy Absolucy deleted the no_stupid_snowflake_shit branch September 28, 2024 05:04
github-actions bot added a commit that referenced this pull request Sep 28, 2024
This was referenced Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants