-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove snowflake conversion immunities #3477
Merged
Absolucy
merged 2 commits into
Monkestation:master
from
RikuTheKillerSS13Forks:no_stupid_snowflake_shit
Sep 28, 2024
Merged
Remove snowflake conversion immunities #3477
Absolucy
merged 2 commits into
Monkestation:master
from
RikuTheKillerSS13Forks:no_stupid_snowflake_shit
Sep 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RikuTheKiller
changed the title
Removes a snowflake bb check for security
Remove snowflake conversion checks
Sep 19, 2024
RikuTheKiller
changed the title
Remove snowflake conversion checks
Remove snowflake conversion immunities (by adding more snowflake behaviour lol)
Sep 19, 2024
RikuTheKiller
force-pushed
the
no_stupid_snowflake_shit
branch
from
September 19, 2024 21:15
f2ef15e
to
ef03144
Compare
RikuTheKiller
changed the title
Remove snowflake conversion immunities (by adding more snowflake behaviour lol)
Remove snowflake conversion immunities
Sep 19, 2024
This was referenced Sep 20, 2024
This was referenced Sep 21, 2024
This was referenced Sep 22, 2024
This was referenced Sep 24, 2024
Open
Closed
Closed
Closed
Closed
This was referenced Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Removes the hardcoded snowflake check that security can't be converted by a blood brother.
Also adds a balloon alert for if you get a second flash. It might be obscured by the flash somewhat but it's better than nothing.
And finally, removes IPC flash protection from conversion by head revs and blood brothers. No, it's not perfect, yes, it's snowflakey, but it's the best I could do without losing my sanity and it's better than nothing.
Why It's Good For The Game
They have mindshields for a fucking reason damnit.
If you go out of your way to remove it, it's fair game.
Also, IPCs sticking around revs has been a long standing issue.
You technically aren't allowed to kill them. But they can just ambush you.
It's bullshit gameplay and shouldn't exist at all ever.
Changelog
🆑
balance: Blood Brothers can now convert members of security if their mindshields are removed.
balance: IPCs are no longer immune to being converted by revolutionaries and blood brothers.
qol: You now get a balloon alert if you get a second flash as a Blood Brother.
/:cl: