Antag selection weighting fixups #3481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Absolucy
force-pushed
the
storyteller-harddelete-fixups-maybe
branch
from
790fccf to
0f43f48
Compare
This was referenced Sep 20, 2024
This was referenced Sep 21, 2024
This was referenced Sep 22, 2024
Open
Closed
This was referenced Sep 25, 2024
Closed
Closed
Closed
This was referenced Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
I was looking through runtimes on the live server, and noticed stuff with midround antag selection, where pick_weighted would complain because there was like a
"": nullin the middle of the input. Looking at the code, I saw several problems, and borbop brought up this may also be causing client hard deletes. So I rewrote some stuff to be more resilient - like just using ckeys instead of/clientobjects as keys inreturn_antag_rep_weightand improving the code of some of the antag selection loops.Testing Evidence
Changelog
🆑
fix: Fixed some logic relating to antag selection (roundstart, midround, and ghost roles), hopefully reducing hard deletes and potential issues.
/:cl: