Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Externals August 2023 #19929

Merged

Conversation

BetsyMcPhail
Copy link
Contributor

@BetsyMcPhail BetsyMcPhail commented Aug 3, 2023

Towards #19865


This change is Reviewable

@BetsyMcPhail BetsyMcPhail added the status: commits are properly curated https://drake.mit.edu/reviewable.html#curated-commits label Aug 3, 2023
Copy link
Contributor Author

@BetsyMcPhail BetsyMcPhail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+@sammy-tri for both reviews please.

See #19865 (comment) for a discussion of no longer checking for petsc updates

Reviewable status: LGTM missing from assignee sammy-tri(platform), needs at least two assigned reviewers, when planning a "properly curated" merge commit the PR must always be rebased onto latest master, missing label for release notes (waiting on @BetsyMcPhail)

@BetsyMcPhail BetsyMcPhail added status: single reviewer ok https://drake.mit.edu/reviewable.html release notes: fix This pull request contains fixes (no new features) labels Aug 3, 2023
Copy link
Contributor

@sammy-tri sammy-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, 1 of 1 files at r2, 1 of 1 files at r3, 1 of 1 files at r4, 1 of 1 files at r5, 1 of 1 files at r6, all commit messages.
Reviewable status: when planning a "properly curated" merge commit the PR must always be rebased onto latest master (waiting on @BetsyMcPhail)

@BetsyMcPhail BetsyMcPhail force-pushed the upgrades-august-2023 branch from 6607023 to c206d01 Compare August 3, 2023 19:57
@jwnimmer-tri jwnimmer-tri merged commit 997c657 into RobotLocomotion:master Aug 3, 2023
@BetsyMcPhail BetsyMcPhail deleted the upgrades-august-2023 branch August 3, 2023 20:18
@BetsyMcPhail BetsyMcPhail restored the upgrades-august-2023 branch August 3, 2023 20:18
@BetsyMcPhail BetsyMcPhail deleted the upgrades-august-2023 branch August 3, 2023 20:18
@BetsyMcPhail BetsyMcPhail restored the upgrades-august-2023 branch August 3, 2023 20:18
@BetsyMcPhail BetsyMcPhail mentioned this pull request Aug 2, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release notes: fix This pull request contains fixes (no new features) status: commits are properly curated https://drake.mit.edu/reviewable.html#curated-commits status: single reviewer ok https://drake.mit.edu/reviewable.html
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants