Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: genAI urdf parser #260

Merged
merged 3 commits into from
Oct 1, 2024
Merged

feat: genAI urdf parser #260

merged 3 commits into from
Oct 1, 2024

Conversation

maciejmajek
Copy link
Member

@maciejmajek maciejmajek commented Oct 1, 2024

Purpose

URDF proves to be a great source of information about robot's links and joints.

Proposed Changes

Implements #69

Issues

Closes #69

Testing

Went through https://github.com/RobotecAI/rai/blob/feat/urdf-parser/docs/create_robots_whoami.md

@maciejmajek maciejmajek requested a review from adamdbrw October 1, 2024 13:10
Copy link
Member

@adamdbrw adamdbrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, but please use os.path.join for portability

@maciejmajek
Copy link
Member Author

Sure. Let me refactor this script in the next PR.

Copy link
Member

@adamdbrw adamdbrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! Nice work. Raise an issue for portability of this script please

@maciejmajek maciejmajek merged commit fe15f7c into development Oct 1, 2024
6 checks passed
@maciejmajek maciejmajek deleted the feat/urdf-parser branch October 1, 2024 14:03
@maciejmajek
Copy link
Member Author

aforementioned issue #261

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Robot description (URDF) service
2 participants