Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix subnet tests #13284

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Fix subnet tests #13284

merged 1 commit into from
Dec 6, 2023

Conversation

Gauravtalreja1
Copy link
Collaborator

Problem Statement

After #12796, we identified a failure for one of negative tests is using invalid_missing_attributes dict to validate if subnet can be updated, after pytest.raises we're also validating if subnet isn't updated, there are invalid keys in use to check subnet key.

Solution

  1. Fixing the negative test with using exact values to check if subnet isn't updated with invalid values
  2. Updating tests to have the teardown
  3. Updating tests to use fauxfactory.gen_netmask instead of fixed netmasks

Related Issues

@Gauravtalreja1
Fix subnet tests
8b39207 
Signed-off-by: Gaurav Talreja <[email protected]>
@Gauravtalreja1 Gauravtalreja1 added TestFailure Issues and PRs related to a test failing in automation CherryPick PR needs CherryPick to previous branches 6.12.z Introduced in or relating directly to Satellite 6.12 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 labels Dec 6, 2023
@Gauravtalreja1 Gauravtalreja1 self-assigned this Dec 6, 2023
@Gauravtalreja1 Gauravtalreja1 requested a review from a team as a code owner December 6, 2023 08:32
@Gauravtalreja1
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_subnet.py

shubhamsg199
shubhamsg199 approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@shubhamsg199 shubhamsg199 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

@shubhamsg199 shubhamsg199 merged commit 8416dde into SatelliteQE:master Dec 6, 2023
13 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 6, 2023
@Gauravtalreja1 @web-flow
Fix subnet tests (#13284)
5164e4c 
Signed-off-by: Gaurav Talreja <[email protected]>
(cherry picked from commit 8416dde)
@Satellite-QE Satellite-QE mentioned this pull request Dec 6, 2023
Merged
github-actions bot pushed a commit that referenced this pull request Dec 6, 2023
@Gauravtalreja1 @web-flow
Fix subnet tests (#13284)
79950fe 
Signed-off-by: Gaurav Talreja <[email protected]>
(cherry picked from commit 8416dde)
github-actions bot pushed a commit that referenced this pull request Dec 6, 2023
@Gauravtalreja1 @web-flow
Fix subnet tests (#13284)
090a3f7 
Signed-off-by: Gaurav Talreja <[email protected]>
(cherry picked from commit 8416dde)
github-actions bot pushed a commit that referenced this pull request Dec 6, 2023
@Gauravtalreja1 @web-flow
Fix subnet tests (#13284)
9a43dcf 
Signed-off-by: Gaurav Talreja <[email protected]>
(cherry picked from commit 8416dde)
This was referenced Dec 6, 2023
Merged
Merged
Merged
@Gauravtalreja1 Gauravtalreja1 deleted the modify-subnet-tests branch December 7, 2023 07:09
damoore044 pushed a commit to damoore044/robottelo that referenced this pull request Dec 11, 2023
@Gauravtalreja1 @damoore044
Fix subnet tests (SatelliteQE#13284)
3532292 
Signed-off-by: Gaurav Talreja <[email protected]>
shweta83 pushed a commit to shweta83/robottelo that referenced this pull request Apr 10, 2024
@Gauravtalreja1 @shweta83
Fix subnet tests (SatelliteQE#13284)
7d44e17 
Signed-off-by: Gaurav Talreja <[email protected]>
@shweta83 shweta83 mentioned this pull request May 17, 2024
Merged
This was referenced May 17, 2024
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shubhamsg199 shubhamsg199 shubhamsg199 approved these changes

@jameerpathan111 jameerpathan111 jameerpathan111 approved these changes

Assignees

@Gauravtalreja1 Gauravtalreja1

Labels
6.12.z Introduced in or relating directly to Satellite 6.12 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches TestFailure Issues and PRs related to a test failing in automation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gauravtalreja1 @jameerpathan111 @shubhamsg199