-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Non tabular output denied for CSV conversion #13737
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyejare
added
6.12.z
Introduced in or relating directly to Satellite 6.12
6.13.z
Introduced in or relating directly to Satellite 6.13
6.14.z
Introduced in or relating directly to Satellite 6.14
6.15.z
Introduced in or relating directly to Satellite 6.15
Urgent Priority
Get this done now
Framework Changes
A modification of the robottelo framework
Critical Severity
CherryPick
PR needs CherryPick to previous branches
labels
Jan 11, 2024
trigger: test-robottelo |
jyejare
force-pushed
the
non_csv_output
branch
from
January 11, 2024 11:25
ea871d0
to
17707a9
Compare
jyejare
force-pushed
the
non_csv_output
branch
from
January 11, 2024 11:29
17707a9
to
4b77b59
Compare
trigger: test-robottelo |
pondrejk
approved these changes
Jan 11, 2024
adarshdubey-star
approved these changes
Jan 11, 2024
This was referenced Jan 11, 2024
Merged
This was referenced Jan 16, 2024
This was referenced Jan 24, 2024
Merged
This broke csv parsing for (valid) csvs without delimiters, e.g.:
Because sniffer can't find a delimiter and thinks it's not a csv. But it is, it has one column called
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
6.12.z
Introduced in or relating directly to Satellite 6.12
6.13.z
Introduced in or relating directly to Satellite 6.13
6.14.z
Introduced in or relating directly to Satellite 6.14
6.15.z
Introduced in or relating directly to Satellite 6.15
CherryPick
PR needs CherryPick to previous branches
Critical Severity
Framework Changes
A modification of the robottelo framework
Urgent Priority
Get this done now
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement
The CLI command output containing non-tabular string is not eligible for CSV conversation.
e.g:
STDOUT like
Here zipping in csv conversion function trying to zip the first row of 2 key_value pairs
Added Rpms: 32, Errata: 4
with 1 row of key_value from next lineTotal steps: 84/84
. Since strict is set toTrue
the numbe of contents from first row and second row should match which does match with the tabular format but not the above-like output. Making the the strict zipping to fail.Solution
Returning the output as is if the output is not sniffed using CSV Sniffer for CSV conversion eligibility.
Trying to make it simple though, we could also return all key-value pairs from such output but if the Team demands for it! Since its not returning all key value pairs for such output nobody complaints about it in the past so for now we should be good with the simple solution.
Related Issues