Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt_demorgan: skip zero width cells #4612

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

georgerennie
Copy link
Collaborator

Fixes #4610

@georgerennie georgerennie force-pushed the george/opt_demorgan_zero_width branch from 589d13b to 58af706 Compare September 24, 2024 13:25
@Ravenslofty
Copy link
Collaborator

Might as well include a testcase for it.

Copy link
Collaborator

@widlarizer widlarizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test reproduces error described in issue, fix looks good

@widlarizer widlarizer merged commit cc17d5b into YosysHQ:main Nov 20, 2024
22 checks passed
@povik
Copy link
Member

povik commented Nov 20, 2024

This one uses the removed read_ilang command and happened to have broken tests on main

georgerennie added a commit to georgerennie/yosys that referenced this pull request Nov 20, 2024
* YosysHQ#4612 was written before read_ilang was deprecated but merged after so caused test failures. This switches read_ilang to read_rtlil
georgerennie added a commit to georgerennie/yosys that referenced this pull request Nov 20, 2024
* YosysHQ#4612 was written before read_ilang was deprecated but merged after so caused test failures. This switches read_ilang to read_rtlil
georgerennie added a commit to georgerennie/yosys that referenced this pull request Nov 21, 2024
* YosysHQ#4612 was written before read_ilang was deprecated but merged after so caused test failures. This switches read_ilang to read_rtlil
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Yosys Synthesis Fails with std::out_of_range Error in OPT_DEMORGAN Pass
4 participants