-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(image_projection_based_fusion): add JSON Schema and remove default value spefications #4902
refactor(image_projection_based_fusion): add JSON Schema and remove default value spefications #4902
Conversation
dede75c
to
22a9f04
Compare
f6ffed4
to
2843d15
Compare
2843d15
to
85a11cf
Compare
@yukke42 @tzhong518 @badai-nguyen Could check the parameters for the packages which each of you worked? |
perception/image_projection_based_fusion/launch/roi_cluster_fusion.launch.xml
Outdated
Show resolved
Hide resolved
@ktro2828 Thank you for your PR. Since the roi_pointcloud_fusion node was added recently, I really appreciate if you also add scheme json for that node's params. autoware.universe/perception/image_projection_based_fusion/src/roi_pointcloud_fusion/node.cpp Lines 35 to 37 in c552c3d
|
fc8b225
to
45c24eb
Compare
@badai-nguyen I added a configuration and schema for |
9657344
to
4baa9e2
Compare
perception/image_projection_based_fusion/config/pointpainting.param.yaml
Show resolved
Hide resolved
perception/image_projection_based_fusion/config/pointpainting.param.yaml
Show resolved
Hide resolved
perception/image_projection_based_fusion/config/pointpainting.param.yaml
Outdated
Show resolved
Hide resolved
perception/image_projection_based_fusion/launch/roi_pointcloud_fusion.launch.xml
Outdated
Show resolved
Hide resolved
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4902 +/- ##
==========================================
- Coverage 15.32% 0.00% -15.33%
==========================================
Files 1721 13 -1708
Lines 118559 1029 -117530
Branches 37995 0 -37995
==========================================
- Hits 18169 0 -18169
+ Misses 79657 1029 -78628
+ Partials 20733 0 -20733
☔ View full report in Codecov by Sentry. |
…eter()` Signed-off-by: ktro2828 <[email protected]>
Signed-off-by: ktro2828 <[email protected]>
Signed-off-by: ktro2828 <[email protected]>
Signed-off-by: ktro2828 <[email protected]>
Signed-off-by: ktro2828 <[email protected]>
Signed-off-by: ktro2828 <[email protected]>
Signed-off-by: ktro2828 <[email protected]>
Signed-off-by: ktro2828 <[email protected]>
Signed-off-by: ktro2828 <[email protected]>
Signed-off-by: ktro2828 <[email protected]>
Signed-off-by: ktro2828 <[email protected]>
4baa9e2
to
22c503d
Compare
Signed-off-by: ktro2828 <[email protected]>
@badai-nguyen Sorry for late to reaction, I fixed all you suggested. |
@ktro2828 The reason is: |
@ktro2828 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…efault value spefications (autowarefoundation#4902) * refactor: add JSON Schema and remove default values in `declare_parameter()` Signed-off-by: ktro2828 <[email protected]> * refactor: update configuration file Signed-off-by: ktro2828 <[email protected]> * refactor: add configuration file and update launcher to load this Signed-off-by: ktro2828 <[email protected]> * refactor: update funsion node configuration Signed-off-by: ktro2828 <[email protected]> * docs: update the document for roi cluster fusion Signed-off-by: ktro2828 <[email protected]> * docs: update documents Signed-off-by: ktro2828 <[email protected]> * refactor: move `debug_mode` into `roi_sync.param.yaml` Signed-off-by: ktro2828 <[email protected]> * refactor: rework parameters for `roi_pointcloud_fusion` Signed-off-by: ktro2828 <[email protected]> * chore: update maintainers Signed-off-by: ktro2828 <[email protected]> * refactor: remove debug_mode Signed-off-by: ktro2828 <[email protected]> * refactor: rename parameter to avoid failure of spell-check Signed-off-by: ktro2828 <[email protected]> * fix: fix typo and parameters for initialization Signed-off-by: ktro2828 <[email protected]> --------- Signed-off-by: ktro2828 <[email protected]>
…efault value spefications (autowarefoundation#4902) * refactor: add JSON Schema and remove default values in `declare_parameter()` Signed-off-by: ktro2828 <[email protected]> * refactor: update configuration file Signed-off-by: ktro2828 <[email protected]> * refactor: add configuration file and update launcher to load this Signed-off-by: ktro2828 <[email protected]> * refactor: update funsion node configuration Signed-off-by: ktro2828 <[email protected]> * docs: update the document for roi cluster fusion Signed-off-by: ktro2828 <[email protected]> * docs: update documents Signed-off-by: ktro2828 <[email protected]> * refactor: move `debug_mode` into `roi_sync.param.yaml` Signed-off-by: ktro2828 <[email protected]> * refactor: rework parameters for `roi_pointcloud_fusion` Signed-off-by: ktro2828 <[email protected]> * chore: update maintainers Signed-off-by: ktro2828 <[email protected]> * refactor: remove debug_mode Signed-off-by: ktro2828 <[email protected]> * refactor: rename parameter to avoid failure of spell-check Signed-off-by: ktro2828 <[email protected]> * fix: fix typo and parameters for initialization Signed-off-by: ktro2828 <[email protected]> --------- Signed-off-by: ktro2828 <[email protected]> Signed-off-by: karishma <[email protected]>
…efault value spefications (autowarefoundation#4902) * refactor: add JSON Schema and remove default values in `declare_parameter()` Signed-off-by: ktro2828 <[email protected]> * refactor: update configuration file Signed-off-by: ktro2828 <[email protected]> * refactor: add configuration file and update launcher to load this Signed-off-by: ktro2828 <[email protected]> * refactor: update funsion node configuration Signed-off-by: ktro2828 <[email protected]> * docs: update the document for roi cluster fusion Signed-off-by: ktro2828 <[email protected]> * docs: update documents Signed-off-by: ktro2828 <[email protected]> * refactor: move `debug_mode` into `roi_sync.param.yaml` Signed-off-by: ktro2828 <[email protected]> * refactor: rework parameters for `roi_pointcloud_fusion` Signed-off-by: ktro2828 <[email protected]> * chore: update maintainers Signed-off-by: ktro2828 <[email protected]> * refactor: remove debug_mode Signed-off-by: ktro2828 <[email protected]> * refactor: rename parameter to avoid failure of spell-check Signed-off-by: ktro2828 <[email protected]> * fix: fix typo and parameters for initialization Signed-off-by: ktro2828 <[email protected]> --------- Signed-off-by: ktro2828 <[email protected]> Signed-off-by: karishma <[email protected]>
…efault value spefications (autowarefoundation#4902) * refactor: add JSON Schema and remove default values in `declare_parameter()` Signed-off-by: ktro2828 <[email protected]> * refactor: update configuration file Signed-off-by: ktro2828 <[email protected]> * refactor: add configuration file and update launcher to load this Signed-off-by: ktro2828 <[email protected]> * refactor: update funsion node configuration Signed-off-by: ktro2828 <[email protected]> * docs: update the document for roi cluster fusion Signed-off-by: ktro2828 <[email protected]> * docs: update documents Signed-off-by: ktro2828 <[email protected]> * refactor: move `debug_mode` into `roi_sync.param.yaml` Signed-off-by: ktro2828 <[email protected]> * refactor: rework parameters for `roi_pointcloud_fusion` Signed-off-by: ktro2828 <[email protected]> * chore: update maintainers Signed-off-by: ktro2828 <[email protected]> * refactor: remove debug_mode Signed-off-by: ktro2828 <[email protected]> * refactor: rename parameter to avoid failure of spell-check Signed-off-by: ktro2828 <[email protected]> * fix: fix typo and parameters for initialization Signed-off-by: ktro2828 <[email protected]> --------- Signed-off-by: ktro2828 <[email protected]>
…efault value spefications (autowarefoundation#4902) * refactor: add JSON Schema and remove default values in `declare_parameter()` Signed-off-by: ktro2828 <[email protected]> * refactor: update configuration file Signed-off-by: ktro2828 <[email protected]> * refactor: add configuration file and update launcher to load this Signed-off-by: ktro2828 <[email protected]> * refactor: update funsion node configuration Signed-off-by: ktro2828 <[email protected]> * docs: update the document for roi cluster fusion Signed-off-by: ktro2828 <[email protected]> * docs: update documents Signed-off-by: ktro2828 <[email protected]> * refactor: move `debug_mode` into `roi_sync.param.yaml` Signed-off-by: ktro2828 <[email protected]> * refactor: rework parameters for `roi_pointcloud_fusion` Signed-off-by: ktro2828 <[email protected]> * chore: update maintainers Signed-off-by: ktro2828 <[email protected]> * refactor: remove debug_mode Signed-off-by: ktro2828 <[email protected]> * refactor: rename parameter to avoid failure of spell-check Signed-off-by: ktro2828 <[email protected]> * fix: fix typo and parameters for initialization Signed-off-by: ktro2828 <[email protected]> --------- Signed-off-by: ktro2828 <[email protected]>
…efault value spefications (autowarefoundation#4902) * refactor: add JSON Schema and remove default values in `declare_parameter()` Signed-off-by: ktro2828 <[email protected]> * refactor: update configuration file Signed-off-by: ktro2828 <[email protected]> * refactor: add configuration file and update launcher to load this Signed-off-by: ktro2828 <[email protected]> * refactor: update funsion node configuration Signed-off-by: ktro2828 <[email protected]> * docs: update the document for roi cluster fusion Signed-off-by: ktro2828 <[email protected]> * docs: update documents Signed-off-by: ktro2828 <[email protected]> * refactor: move `debug_mode` into `roi_sync.param.yaml` Signed-off-by: ktro2828 <[email protected]> * refactor: rework parameters for `roi_pointcloud_fusion` Signed-off-by: ktro2828 <[email protected]> * chore: update maintainers Signed-off-by: ktro2828 <[email protected]> * refactor: remove debug_mode Signed-off-by: ktro2828 <[email protected]> * refactor: rename parameter to avoid failure of spell-check Signed-off-by: ktro2828 <[email protected]> * fix: fix typo and parameters for initialization Signed-off-by: ktro2828 <[email protected]> --------- Signed-off-by: ktro2828 <[email protected]>
Description
related PR: autowarefoundation/autoware_launch#739
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.