Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(image_projection_based_fusion): add JSON Schema and remove default value spefications #4902

Conversation

ktro2828
Copy link
Contributor

@ktro2828 ktro2828 commented Sep 6, 2023

Description

related PR: autowarefoundation/autoware_launch#739

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Sep 6, 2023
@ktro2828 ktro2828 force-pushed the refactor/image_projection_based_fusion/json_schema branch from dede75c to 22a9f04 Compare September 7, 2023 15:42
@github-actions github-actions bot added the type:documentation Creating or refining documentation. (auto-assigned) label Sep 12, 2023
@ktro2828 ktro2828 force-pushed the refactor/image_projection_based_fusion/json_schema branch from f6ffed4 to 2843d15 Compare September 12, 2023 13:45
@ktro2828 ktro2828 force-pushed the refactor/image_projection_based_fusion/json_schema branch from 2843d15 to 85a11cf Compare September 22, 2023 09:01
@ktro2828 ktro2828 marked this pull request as ready for review September 22, 2023 09:04
@ktro2828
Copy link
Contributor Author

@yukke42 @tzhong518 @badai-nguyen Could check the parameters for the packages which each of you worked?

@badai-nguyen
Copy link
Contributor

@ktro2828 Thank you for your PR. Since the roi_pointcloud_fusion node was added recently, I really appreciate if you also add scheme json for that node's params.

fuse_unknown_only_ = declare_parameter<bool>("fuse_unknown_only");
min_cluster_size_ = declare_parameter<int>("min_cluster_size");
cluster_2d_tolerance_ = declare_parameter<double>("cluster_2d_tolerance");

@ktro2828 ktro2828 force-pushed the refactor/image_projection_based_fusion/json_schema branch from fc8b225 to 45c24eb Compare September 28, 2023 05:39
@ktro2828
Copy link
Contributor Author

ktro2828 commented Sep 28, 2023

@badai-nguyen I added a configuration and schema for roi_pointcloud_fusion in 130791e

@miursh miursh added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Oct 13, 2023
@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Attention: 130 lines in your changes are missing coverage. Please review.

Comparison is base (765a596) 15.32% compared to head (7b03f74) 0.00%.
Report is 177 commits behind head on main.

Files Patch % Lines
.../image_projection_based_fusion/src/fusion_node.cpp 0.00% 33 Missing ⚠️
...ion_based_fusion/src/pointpainting_fusion/node.cpp 0.00% 28 Missing ⚠️
...age_projection_based_fusion/src/utils/geometry.cpp 0.00% 22 Missing ⚠️
...sion/src/pointpainting_fusion/preprocess_kernel.cu 0.00% 18 Missing ⚠️
...usion/src/pointpainting_fusion/voxel_generator.cpp 0.00% 13 Missing ⚠️
...ion/src/pointpainting_fusion/pointpainting_trt.cpp 0.00% 9 Missing ⚠️
...ction_based_fusion/src/roi_cluster_fusion/node.cpp 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #4902       +/-   ##
==========================================
- Coverage   15.32%   0.00%   -15.33%     
==========================================
  Files        1721      13     -1708     
  Lines      118559    1029   -117530     
  Branches    37995       0    -37995     
==========================================
- Hits        18169       0    -18169     
+ Misses      79657    1029    -78628     
+ Partials    20733       0    -20733     
Flag Coverage Δ
differential 0.00% <0.00%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ktro2828 ktro2828 force-pushed the refactor/image_projection_based_fusion/json_schema branch from 4baa9e2 to 22c503d Compare December 8, 2023 03:41
@ktro2828
Copy link
Contributor Author

ktro2828 commented Dec 8, 2023

@badai-nguyen Sorry for late to reaction, I fixed all you suggested.

@badai-nguyen
Copy link
Contributor

badai-nguyen commented Dec 15, 2023

@ktro2828
All image_projection_based_fusion releaded nodes still cannot be loaded with autoware
[ERROR] [roi_detected_object_fusion_node-51]: process has died [pid 57163, exit code -6, cmd '/home/autoware/autoware/install/image_projection_based_fusion/lib/image_projection_based_fusion/roi_detected_object_fusion_node --ros-args -r __node:=roi_detected_object_fusion -r __ns:=/perception/object_recognition/detection -p use_sim_time:=True -p wheel_radius:=0.383 -p wheel_width:=0.235 -p wheel_base:=2.79 -p wheel_tread:=1.64 -p front_overhang:=1.0 -p rear_overhang:=1.1 -p left_overhang:=0.128 -p right_overhang:=0.128 -p vehicle_height:=2.5 -p max_steer_angle:=0.7 --params-file /tmp/launch_params_y3act209 --params-file /home/autoware/autoware/install/image_projection_based_fusion/share/image_projection_based_fusion/config/roi_detected_object_fusion.param.yaml --params-file /home/autoware/autoware/install/autoware_launch/share/autoware_launch/config/perception/object_recognition/detection/image_projection_based_fusion/roi_sync.param.yaml --params-file /tmp/launch_params_1h8tfapn --params-file /tmp/launch_params_nl5xikak --params-file /tmp/launch_params_86kncd14 --params-file /tmp/launch_params_s7tl5q98 --params-file /tmp/launch_params_f7utsrw3 --params-file /tmp/launch_params_sj8c3jdo --params-file /tmp/launch_params_94a3_iuw --params-file /tmp/launch_params_70fyqug7 --params-file /tmp/launch_params_fc6kx_kj --params-file /tmp/launch_params_4s08xmb_ --params-file /tmp/launch_params_evx9gfnf --params-file /tmp/launch_params_bdmn5ypu --params-file /tmp/launch_params_0x0ky2ub --params-file /tmp/launch_params__v_2dkbe --params-file /tmp/launch_params_5ze5s4hs --params-file /tmp/launch_params_swedhxjf --params-file /tmp/launch_params_zcd9mfd2 --params-file /tmp/launch_params_mlp_7op8 --params-file /tmp/launch_params_9tp9l3yw --params-file /tmp/launch_params_w7wsi1c1 --params-file /tmp/launch_params_x8ora7is --params-file /tmp/launch_params__bgv8bwh --params-file /tmp/launch_params_4y8erxph --params-file /tmp/launch_params_ych09njm -r input:=centerpoint/objects -r output:=centerpoint/roi_fusion/objects'].

The reason is:
[roi_detected_object_fusion_node-51] what(): Statically typed parameter 'filter_scope_min_x' must be initialized.

@badai-nguyen
Copy link
Contributor

badai-nguyen commented Dec 15, 2023

@ktro2828
I think the roi_sync.param.yaml also need to be updated. I created PR for that autowarefoundation/autoware_launch#739

@badai-nguyen badai-nguyen self-requested a review December 15, 2023 07:41
Copy link
Contributor

@badai-nguyen badai-nguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@badai-nguyen badai-nguyen merged commit cc0b108 into autowarefoundation:main Dec 15, 2023
21 of 25 checks passed
danielsanchezaran pushed a commit to tier4/autoware.universe that referenced this pull request Dec 15, 2023
…efault value spefications (autowarefoundation#4902)

* refactor: add JSON Schema and remove default values in `declare_parameter()`

Signed-off-by: ktro2828 <[email protected]>

* refactor: update configuration file

Signed-off-by: ktro2828 <[email protected]>

* refactor: add configuration file and update launcher to load this

Signed-off-by: ktro2828 <[email protected]>

* refactor: update funsion node configuration

Signed-off-by: ktro2828 <[email protected]>

* docs: update the document for roi cluster fusion

Signed-off-by: ktro2828 <[email protected]>

* docs: update documents

Signed-off-by: ktro2828 <[email protected]>

* refactor: move `debug_mode` into `roi_sync.param.yaml`

Signed-off-by: ktro2828 <[email protected]>

* refactor: rework parameters for `roi_pointcloud_fusion`

Signed-off-by: ktro2828 <[email protected]>

* chore: update maintainers

Signed-off-by: ktro2828 <[email protected]>

* refactor: remove debug_mode

Signed-off-by: ktro2828 <[email protected]>

* refactor: rename parameter to avoid failure of spell-check

Signed-off-by: ktro2828 <[email protected]>

* fix: fix typo and parameters for initialization

Signed-off-by: ktro2828 <[email protected]>

---------

Signed-off-by: ktro2828 <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Dec 19, 2023
…efault value spefications (autowarefoundation#4902)

* refactor: add JSON Schema and remove default values in `declare_parameter()`

Signed-off-by: ktro2828 <[email protected]>

* refactor: update configuration file

Signed-off-by: ktro2828 <[email protected]>

* refactor: add configuration file and update launcher to load this

Signed-off-by: ktro2828 <[email protected]>

* refactor: update funsion node configuration

Signed-off-by: ktro2828 <[email protected]>

* docs: update the document for roi cluster fusion

Signed-off-by: ktro2828 <[email protected]>

* docs: update documents

Signed-off-by: ktro2828 <[email protected]>

* refactor: move `debug_mode` into `roi_sync.param.yaml`

Signed-off-by: ktro2828 <[email protected]>

* refactor: rework parameters for `roi_pointcloud_fusion`

Signed-off-by: ktro2828 <[email protected]>

* chore: update maintainers

Signed-off-by: ktro2828 <[email protected]>

* refactor: remove debug_mode

Signed-off-by: ktro2828 <[email protected]>

* refactor: rename parameter to avoid failure of spell-check

Signed-off-by: ktro2828 <[email protected]>

* fix: fix typo and parameters for initialization

Signed-off-by: ktro2828 <[email protected]>

---------

Signed-off-by: ktro2828 <[email protected]>
Signed-off-by: karishma <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Dec 19, 2023
…efault value spefications (autowarefoundation#4902)

* refactor: add JSON Schema and remove default values in `declare_parameter()`

Signed-off-by: ktro2828 <[email protected]>

* refactor: update configuration file

Signed-off-by: ktro2828 <[email protected]>

* refactor: add configuration file and update launcher to load this

Signed-off-by: ktro2828 <[email protected]>

* refactor: update funsion node configuration

Signed-off-by: ktro2828 <[email protected]>

* docs: update the document for roi cluster fusion

Signed-off-by: ktro2828 <[email protected]>

* docs: update documents

Signed-off-by: ktro2828 <[email protected]>

* refactor: move `debug_mode` into `roi_sync.param.yaml`

Signed-off-by: ktro2828 <[email protected]>

* refactor: rework parameters for `roi_pointcloud_fusion`

Signed-off-by: ktro2828 <[email protected]>

* chore: update maintainers

Signed-off-by: ktro2828 <[email protected]>

* refactor: remove debug_mode

Signed-off-by: ktro2828 <[email protected]>

* refactor: rename parameter to avoid failure of spell-check

Signed-off-by: ktro2828 <[email protected]>

* fix: fix typo and parameters for initialization

Signed-off-by: ktro2828 <[email protected]>

---------

Signed-off-by: ktro2828 <[email protected]>
Signed-off-by: karishma <[email protected]>
@ktro2828 ktro2828 deleted the refactor/image_projection_based_fusion/json_schema branch April 2, 2024 18:04
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
…efault value spefications (autowarefoundation#4902)

* refactor: add JSON Schema and remove default values in `declare_parameter()`

Signed-off-by: ktro2828 <[email protected]>

* refactor: update configuration file

Signed-off-by: ktro2828 <[email protected]>

* refactor: add configuration file and update launcher to load this

Signed-off-by: ktro2828 <[email protected]>

* refactor: update funsion node configuration

Signed-off-by: ktro2828 <[email protected]>

* docs: update the document for roi cluster fusion

Signed-off-by: ktro2828 <[email protected]>

* docs: update documents

Signed-off-by: ktro2828 <[email protected]>

* refactor: move `debug_mode` into `roi_sync.param.yaml`

Signed-off-by: ktro2828 <[email protected]>

* refactor: rework parameters for `roi_pointcloud_fusion`

Signed-off-by: ktro2828 <[email protected]>

* chore: update maintainers

Signed-off-by: ktro2828 <[email protected]>

* refactor: remove debug_mode

Signed-off-by: ktro2828 <[email protected]>

* refactor: rename parameter to avoid failure of spell-check

Signed-off-by: ktro2828 <[email protected]>

* fix: fix typo and parameters for initialization

Signed-off-by: ktro2828 <[email protected]>

---------

Signed-off-by: ktro2828 <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
…efault value spefications (autowarefoundation#4902)

* refactor: add JSON Schema and remove default values in `declare_parameter()`

Signed-off-by: ktro2828 <[email protected]>

* refactor: update configuration file

Signed-off-by: ktro2828 <[email protected]>

* refactor: add configuration file and update launcher to load this

Signed-off-by: ktro2828 <[email protected]>

* refactor: update funsion node configuration

Signed-off-by: ktro2828 <[email protected]>

* docs: update the document for roi cluster fusion

Signed-off-by: ktro2828 <[email protected]>

* docs: update documents

Signed-off-by: ktro2828 <[email protected]>

* refactor: move `debug_mode` into `roi_sync.param.yaml`

Signed-off-by: ktro2828 <[email protected]>

* refactor: rework parameters for `roi_pointcloud_fusion`

Signed-off-by: ktro2828 <[email protected]>

* chore: update maintainers

Signed-off-by: ktro2828 <[email protected]>

* refactor: remove debug_mode

Signed-off-by: ktro2828 <[email protected]>

* refactor: rename parameter to avoid failure of spell-check

Signed-off-by: ktro2828 <[email protected]>

* fix: fix typo and parameters for initialization

Signed-off-by: ktro2828 <[email protected]>

---------

Signed-off-by: ktro2828 <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
…efault value spefications (autowarefoundation#4902)

* refactor: add JSON Schema and remove default values in `declare_parameter()`

Signed-off-by: ktro2828 <[email protected]>

* refactor: update configuration file

Signed-off-by: ktro2828 <[email protected]>

* refactor: add configuration file and update launcher to load this

Signed-off-by: ktro2828 <[email protected]>

* refactor: update funsion node configuration

Signed-off-by: ktro2828 <[email protected]>

* docs: update the document for roi cluster fusion

Signed-off-by: ktro2828 <[email protected]>

* docs: update documents

Signed-off-by: ktro2828 <[email protected]>

* refactor: move `debug_mode` into `roi_sync.param.yaml`

Signed-off-by: ktro2828 <[email protected]>

* refactor: rework parameters for `roi_pointcloud_fusion`

Signed-off-by: ktro2828 <[email protected]>

* chore: update maintainers

Signed-off-by: ktro2828 <[email protected]>

* refactor: remove debug_mode

Signed-off-by: ktro2828 <[email protected]>

* refactor: rename parameter to avoid failure of spell-check

Signed-off-by: ktro2828 <[email protected]>

* fix: fix typo and parameters for initialization

Signed-off-by: ktro2828 <[email protected]>

---------

Signed-off-by: ktro2828 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants