fix(tracking_object_merger): fix bug and rework parameters #6168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kminoda <[email protected]>
Signed-off-by: kminoda <[email protected]>
github-actions
bot
added
the
component:perception
Merged
4 tasks
kminoda
changed the title
yukkysaito
approved these changes
Jan 26, 2024
kminoda
added
the
run:build-and-test-differential
|
@YoshiRi Would appreciate if you could briefly check this PR 🙏 |
YoshiRi
requested changes
Jan 26, 2024
perception/tracking_object_merger/config/decorative_tracker_merger.param.yaml
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6168 +/- ##
==========================================
+ Coverage 14.58% 14.61% +0.02%
==========================================
Files 1871 1868 -3
Lines 127545 127248 -297
Branches 37311 37297 -14
==========================================
- Hits 18606 18594 -12
+ Misses 88019 87742 -277
+ Partials 20920 20912 -8
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@YoshiRi Would you also approve autowarefoundation/autoware_launch#823? |
kyoichi-sugahara
pushed a commit
to kyoichi-sugahara/autoware.universe
that referenced
this pull request
Jan 29, 2024
…oundation#6168) * chore(tracking_object_merger): use config Signed-off-by: kminoda <[email protected]> * fix(tracking_object_merger): fix bug and use param file Signed-off-by: kminoda <[email protected]> * Update perception/tracking_object_merger/config/decorative_tracker_merger.param.yaml --------- Signed-off-by: kminoda <[email protected]> Co-authored-by: Yoshi Ri <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…oundation#6168) * chore(tracking_object_merger): use config Signed-off-by: kminoda <[email protected]> * fix(tracking_object_merger): fix bug and use param file Signed-off-by: kminoda <[email protected]> * Update perception/tracking_object_merger/config/decorative_tracker_merger.param.yaml --------- Signed-off-by: kminoda <[email protected]> Co-authored-by: Yoshi Ri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use param file as well as fixing a bug in param name.
Must be merged with autowarefoundation/autoware_launch#823
Tests performed
Launch Autoware and parameters are successfully loaded.
Effects on system behavior
Now
logging_file_pathwill be/tmp/decorative_tracker_merger.logandenable_loggingwill befalseby default in Autoware (see autowarefoundation/autoware_launch#823).Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.