Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(simple_planning_simulator): fix steering bias model #6240

Merged
merged 12 commits into from
Feb 5, 2024

add comments

30ea518
Select commit
Loading
Failed to load commit list.
Merged

fix(simple_planning_simulator): fix steering bias model #6240

add comments
30ea518
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Jan 31, 2024 in 32s

CodeScene PR Check

✅ Code Health Quality Gates: OK

  • Declining Code Health: 0 findings(s) 🚩
  • Improving Code Health: 1 findings(s) ✅
  • Affected Hotspots: 0 files(s) 🔥

Recommended Review Level: Lightweight sanity check
View detailed results in CodeScene

Details

✅ Improving Code Health:

  • Large Method simple_planning_simulator_core.cpp: SimplePlanningSimulator::SimplePlanningSimulator

Annotations

Check notice on line 104 in simulator/simple_planning_simulator/src/simple_planning_simulator/simple_planning_simulator_core.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

✅ Getting better: Large Method 

SimplePlanningSimulator::SimplePlanningSimulator decreases from 98 to 97 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
View more details on CodeScene Delta Analysis