Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(multi_object_tracker): fix typo in param name and change default value #785

Merged

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Jan 12, 2024

Description

Fix param name typo as well as changing the default value so that it publishes the processed time

Tests performed

Not applicable

Effects on system behavior

Not applicable

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@kminoda kminoda requested a review from miursh January 12, 2024 11:54
Copy link
Contributor

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
cc @YoshiRi

@kminoda kminoda changed the title fix(multi_object_tracker): fix typo in param name feat(multi_object_tracker): fix typo in param name and change default value Jan 12, 2024
@kminoda kminoda enabled auto-merge (squash) January 12, 2024 11:56
@kminoda kminoda merged commit 10b95d7 into autowarefoundation:main Jan 12, 2024
12 checks passed
@kminoda kminoda deleted the fix/multi_object_tracker/fix_typo branch January 12, 2024 11:57
kminoda added a commit to tier4/autoware_launch that referenced this pull request Jan 12, 2024
… value (autowarefoundation#785)

* fix(multi_object_tracker): fix typo in param name

Signed-off-by: kminoda <[email protected]>

* feat: update default param

Signed-off-by: kminoda <[email protected]>

---------

Signed-off-by: kminoda <[email protected]>
tkimura4 pushed a commit to tier4/autoware_launch that referenced this pull request Jan 12, 2024
… value (#271)

feat(multi_object_tracker): fix typo in param name and change default value (autowarefoundation#785)

* fix(multi_object_tracker): fix typo in param name



* feat: update default param



---------

Signed-off-by: kminoda <[email protected]>
takayuki5168 pushed a commit to tier4/autoware_launch that referenced this pull request Jan 13, 2024
… value (autowarefoundation#785)

* fix(multi_object_tracker): fix typo in param name

Signed-off-by: kminoda <[email protected]>

* feat: update default param

Signed-off-by: kminoda <[email protected]>

---------

Signed-off-by: kminoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants