Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load and insert class and property assertions from a YAML file #17

Conversation

Sushant-Chavan
Copy link
Contributor

@Sushant-Chavan Sushant-Chavan commented Mar 13, 2020

The PR adds support to load custom assertions about instances of classes or properties between classes from a YAML file and insert them into an ontology using the ontology interface.

Changelog

  • Updated the onotology_interface to support inserting class and property assertions.
  • Validation is performed while inserting assertions to check if the classes, instances or properties exist in the ontology.
  • Implemented a new script to load custom class and property assertions from a YAML file and use the ontology_interface to insert these assertions into an ontology.
  • Added a sample assertions YAML file containing a few class and property assertions.
  • Removed duplicated Furniture class declaration from the apartment_go_2019.owl ontology.
  • Fixed capitalization of class names in the apartment_go_2019.owl ontology.

Closes #2
Related to #YY

Checklist:

  • My code doesn't contain unnecessary comment blocks (e.g. unused code, templates of package.xml or CMakeLists.txt)
  • I have updated the package.xml and CMakeLists.txt with the correct dependencies.
  • I have updated the documentation accordingly.

@alex-mitrevski
Copy link
Member

Hey @Sushant-Chavan, which branch did you branch off from? You're repeating some of the functionalities that I've already added in my WIP branch https://github.com/b-it-bots/mas_knowledge_base/tree/feature/ontology-to-kb-export, such as getting all class and property names

@Sushant-Chavan
Copy link
Contributor Author

Hi @alex-mitrevski, I branched off from the master branch (since the develop is behind master) and didn't find these changes there. Should I merge your WIP branch into mine and remove the duplicate code?

@Sushant-Chavan Sushant-Chavan changed the base branch from master to feature/ontology-to-kb-export March 13, 2020 17:29
@Sushant-Chavan Sushant-Chavan changed the title WIP: Load and insert class and property assertions from a YAML file Load and insert class and property assertions from a YAML file Mar 13, 2020
@alex-mitrevski alex-mitrevski merged commit a6ad57d into b-it-bots:feature/ontology-to-kb-export Mar 13, 2020
@Sushant-Chavan Sushant-Chavan deleted the feature/ABox branch March 13, 2020 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Populate ABox from files
2 participants