Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Setup Travis CI to run unit tests for the OntologyQueryInterface #22

Merged
merged 9 commits into from
Mar 15, 2020
Merged

[Feature] Setup Travis CI to run unit tests for the OntologyQueryInterface #22

merged 9 commits into from
Mar 15, 2020

Conversation

Sushant-Chavan
Copy link
Contributor

@Sushant-Chavan Sushant-Chavan commented Mar 14, 2020 •
edited
Loading

This PR implements unit-tests for validating the OntologyQueryInterface using a new, simple apartment ontology. These unit-tests can then be used during CI with Travis.

Changelog

  • Added a new bare minimal apartment ontology called sample.owl based on the tutorials
  • Added unit tests for all the query APIs of the OntologyQueryInterface
  • Fixed the issues detected by the unit tests in the OntologyQueryInterface
  • Added TravisCI config file to install ROS and run the unit-tests

Related PRs

Closes #20
Related b-it-bots/mas_tutorials#14

Checklist:

  • My code doesn't contain unnecessary comment blocks (e.g. unused code, templates of package.xml or CMakeLists.txt)
  • I have updated the package.xml and CMakeLists.txt with the correct dependencies.
  • I have updated the documentation accordingly.

@Sushant-Chavan
Add Travis config
c5663da 
Install catkin_pkg during travis builds


Change argument to setup.py to install


install packages to user site-packages dir
@Sushant-Chavan Sushant-Chavan force-pushed the feature/ontology-ci-unit-tests branch from 9eb7675 to c5663da Compare March 14, 2020 19:52
@Sushant-Chavan
Copy link
Contributor Author

@alex-mitrevski I need your help for installing the mas_knowledge_base repository in Travis. The mas_knowledge_utils module seems to be installed according to the logs. But when running the test script, python complains that the mas_knowledge_utils module is not found. Any ideas on how I could fix this?

@alex-mitrevski
Copy link
Member

Hmm, not sure what the problem could be. Maybe try installing the package without --user?

@Sushant-Chavan
Copy link
Contributor Author

@alex-mitrevski, I already tried that, but that doesn't work either. Can I go ahead and install ROS kinetic bare bones in Travis? Although that seems a lot of overhead to me, I can't think of any other solution due to my lack of experience with distutils and setting up custom python modules.

@alex-mitrevski
Copy link
Member

Sure, go ahead. We'll anyway need that for the knowledge base interface.

@Sushant-Chavan Sushant-Chavan force-pushed the feature/ontology-ci-unit-tests branch from 92cbf76 to 806b06b Compare March 14, 2020 22:29
@Sushant-Chavan Sushant-Chavan force-pushed the feature/ontology-ci-unit-tests branch from 4583d95 to 9809a64 Compare March 14, 2020 22:48
@Sushant-Chavan Sushant-Chavan changed the title WIP: [Feature] Setup Travis CI to run unit tests for the OntologyQueryInterface [Feature] Setup Travis CI to run unit tests for the OntologyQueryInterface Mar 14, 2020
@alex-mitrevski alex-mitrevski merged commit 8186b2b into feature/ontology-to-kb-export Mar 15, 2020
@Sushant-Chavan Sushant-Chavan deleted the feature/ontology-ci-unit-tests branch March 15, 2020 09:18
This was referenced Mar 15, 2020
Closed
Merged
@alex-mitrevski alex-mitrevski mentioned this pull request Dec 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-mitrevski alex-mitrevski alex-mitrevski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sushant-Chavan @alex-mitrevski