Add the Max and MinSquareSize as a parameter to the payment module
#183
Assignees
Comments
This was referenced Aug 24, 2022
This was referenced Sep 19, 2022
|
Note: |
|
yeah, we still need to add this as a parameter. At the time of making this, it was unclear if we wanted to leave it as a constant to force a hardfork or if we want a param that can be changed by over two thirds of the voting power via the gov module. Now we want the latter. |
rootulp
changed the title
MaxSquareSize as a parameter to the payment moduleMaxSquareSize as a parameter to the payment module
|
While we're at it, we should also add the min square size as a param |
evan-forbes
changed the title
MaxSquareSize as a parameter to the payment moduleMax and MinSquareSize as a parameter to the payment module
This was referenced Oct 20, 2022
rahulghangas
added a commit
that referenced
this issue
Nov 10, 2022
Adds `minSquareSize` and `maxSquareSize` as params to the payment module. Defines relevant stores and queries Relevant changes in `proto/payment/*` `x/payment/keeper*` `x/payment/types/*` - [x] closes #183 Note: The constants that currently define min/max square size have not been deprecated, will do so in another PR
Repository owner
moved this from TODO
to Done
in Celestia Node
Nov 10, 2022
rach-id
pushed a commit
to rach-id/celestia-app
that referenced
this issue
Nov 16, 2022
Adds `minSquareSize` and `maxSquareSize` as params to the payment module. Defines relevant stores and queries Relevant changes in `proto/payment/*` `x/payment/keeper*` `x/payment/types/*` - [x] closes celestiaorg#183 Note: The constants that currently define min/max square size have not been deprecated, will do so in another PR
rach-id
pushed a commit
to rach-id/celestia-app
that referenced
this issue
Nov 16, 2022
Adds `minSquareSize` and `maxSquareSize` as params to the payment module. Defines relevant stores and queries Relevant changes in `proto/payment/*` `x/payment/keeper*` `x/payment/types/*` - [x] closes celestiaorg#183 Note: The constants that currently define min/max square size have not been deprecated, will do so in another PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, the
MaxSquareSizeconstant has to be in celestia-core, but ideally, it should be a parameter in the app. This way, it doesn't require a hardfork to change, we only need 2/3 of the voting power to vote for a proposal using the gov module.As celestia-core might need that constant and we cannot have import cycles, we can either manually mirror that parameter in celestia-core, or after we begin using ABCI++. It is possible that celestia-core will no longer need to know that constant, because the filling of the data square could happen entirely on the application side.
releated to #168
The text was updated successfully, but these errors were encountered: