Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20677] Add type support regeneration utility #108

Merged
merged 3 commits into from
Mar 22, 2024

Conversation

EduPonz
Copy link

@EduPonz EduPonz commented Mar 21, 2024

This PR adds a utility so that regenerating the repository various type supports is easier.

@EduPonz EduPonz added this to the v1.4.1 milestone Mar 21, 2024
Copy link
Contributor

@JesusPoderoso JesusPoderoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JesusPoderoso JesusPoderoso added the ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. label Mar 21, 2024
@EduPonz EduPonz merged commit 6e95da6 into main Mar 22, 2024
6 checks passed
@EduPonz EduPonz deleted the feature/generate_types_script branch March 22, 2024 16:03
JesusPoderoso pushed a commit that referenced this pull request Jul 22, 2024
* Refs #20677: Add type support regeneration utility

Signed-off-by: EduPonz <[email protected]>

* Refs #20677: Remove legacy script

Signed-off-by: EduPonz <[email protected]>

* Refs #20677: Apply suggestions

Signed-off-by: EduPonz <[email protected]>

---------

Signed-off-by: EduPonz <[email protected]>
MiguelCompany pushed a commit that referenced this pull request Jul 22, 2024
* Add type support regeneration utility (#108)

* Refs #20677: Add type support regeneration utility

Signed-off-by: EduPonz <[email protected]>

* Refs #20677: Remove legacy script

Signed-off-by: EduPonz <[email protected]>

* Refs #20677: Apply suggestions

Signed-off-by: EduPonz <[email protected]>

---------

Signed-off-by: EduPonz <[email protected]>

* Hotfix: type regeneration script (#115)

* Refs #20734: fix type regeneration script

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #20734: regenerate types using script

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

---------

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #21226: Adjust script to python version 1.2.x

Signed-off-by: JesusPoderoso <[email protected]>

---------

Signed-off-by: EduPonz <[email protected]>
Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
Signed-off-by: JesusPoderoso <[email protected]>
Co-authored-by: Eduardo Ponz Segrelles <[email protected]>
Co-authored-by: José Luis Bueno López <[email protected]>
mergify bot pushed a commit that referenced this pull request Jul 26, 2024
* Add type support regeneration utility (#108)

* Refs #20677: Add type support regeneration utility

Signed-off-by: EduPonz <[email protected]>

* Refs #20677: Remove legacy script

Signed-off-by: EduPonz <[email protected]>

* Refs #20677: Apply suggestions

Signed-off-by: EduPonz <[email protected]>

---------

Signed-off-by: EduPonz <[email protected]>

* Hotfix: type regeneration script (#115)

* Refs #20734: fix type regeneration script

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #20734: regenerate types using script

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

---------

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #21226: Adjust script to python version 1.2.x

Signed-off-by: JesusPoderoso <[email protected]>

---------

Signed-off-by: EduPonz <[email protected]>
Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
Signed-off-by: JesusPoderoso <[email protected]>
Co-authored-by: Eduardo Ponz Segrelles <[email protected]>
Co-authored-by: José Luis Bueno López <[email protected]>
(cherry picked from commit 8057dd0)
JesusPoderoso added a commit that referenced this pull request Sep 2, 2024
* Add type support regeneration utility (#108)

* Refs #20677: Add type support regeneration utility

Signed-off-by: EduPonz <[email protected]>

* Refs #20677: Remove legacy script

Signed-off-by: EduPonz <[email protected]>

* Refs #20677: Apply suggestions

Signed-off-by: EduPonz <[email protected]>

---------

Signed-off-by: EduPonz <[email protected]>

* Hotfix: type regeneration script (#115)

* Refs #20734: fix type regeneration script

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #20734: regenerate types using script

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

---------

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #21226: Adjust script to python version 1.2.x

Signed-off-by: JesusPoderoso <[email protected]>

---------

Signed-off-by: EduPonz <[email protected]>
Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
Signed-off-by: JesusPoderoso <[email protected]>
Co-authored-by: Eduardo Ponz Segrelles <[email protected]>
Co-authored-by: José Luis Bueno López <[email protected]>
(cherry picked from commit 8057dd0)

Co-authored-by: Jesús Poderoso <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants