Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20722] Force unlimited ResourceLimits if lower or equal to zero #4617

Merged
merged 4 commits into from
Apr 4, 2024
Merged

[20722] Force unlimited ResourceLimits if lower or equal to zero #4617

merged 4 commits into from
Apr 4, 2024

Conversation

JesusPoderoso
Copy link
Contributor

@JesusPoderoso JesusPoderoso commented Mar 25, 2024 •
edited
Loading

Description

This PR forces the ResourceLimitsQoS values (max_samples, max_instances and max_samples_per_instance) to be considered as unlimited if a value greater than zero is NOT provided.

@Mergifyio backport 2.13.x 2.10.x 2.6.x

Fixes #4609

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
    Related documentation PR: [20722] Update docs to force unlimited ResourceLimits if lower or equal to zero Fast-DDS-docs#738
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@JesusPoderoso JesusPoderoso added this to the v2.14.1 milestone Mar 25, 2024
@JesusPoderoso JesusPoderoso self-assigned this Mar 25, 2024
@JesusPoderoso JesusPoderoso added the needs-review PR that is ready to be reviewed label Mar 25, 2024
@JesusPoderoso JesusPoderoso requested a review from a team March 25, 2024 15:59
@github-actions github-actions bot added the ci-pending PR which CI is running label Mar 25, 2024
@JesusPoderoso JesusPoderoso removed the request for review from a team March 25, 2024 16:00
@EduPonz EduPonz changed the title [20638] Force unlimited ResourceLimits if lower or equal to zero [20722] Force unlimited ResourceLimits if lower or equal to zero Apr 2, 2024
@JesusPoderoso JesusPoderoso mentioned this pull request Apr 2, 2024
Merged
7 tasks
@JesusPoderoso JesusPoderoso requested a review from EduPonz April 2, 2024 21:32
EduPonz
EduPonz suggested changes Apr 3, 2024
View reviewed changes
Copy link

@EduPonz EduPonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need a test for creating the entities with negative values for resource limits

@EduPonz
Copy link

EduPonz commented Apr 3, 2024

@Mergifyio backport 2.13.x 2.10.x 2.6.x

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 3, 2024 •
edited
Loading

backport 2.13.x 2.10.x 2.6.x

✅ Backports have been created

@JesusPoderoso JesusPoderoso requested a review from EduPonz April 3, 2024 05:56
EduPonz
EduPonz previously approved these changes Apr 3, 2024
View reviewed changes
@EduPonz
Copy link

EduPonz commented Apr 3, 2024

@richiprosima please test this

@EduPonz EduPonz removed the needs-review PR that is ready to be reviewed label Apr 3, 2024
@JesusPoderoso
Refs #20722: Fix test typo
16eff5b 
Signed-off-by: JesusPoderoso <[email protected]>
@JesusPoderoso JesusPoderoso requested a review from EduPonz April 3, 2024 08:31
@JesusPoderoso
Copy link
Contributor Author

@richiprosima please test this

@EduPonz EduPonz merged commit 31b8ad1 into master Apr 4, 2024
11 of 16 checks passed
@EduPonz EduPonz deleted the hotfix/4609 branch April 4, 2024 10:40
@EduPonz EduPonz removed the ci-pending PR which CI is running label Apr 4, 2024
mergify bot pushed a commit that referenced this pull request Apr 4, 2024
@JesusPoderoso @mergify
Force unlimited ResourceLimits if lower or equal to zero (#4617)
73e2b14 
* Refs #20638: Force unlimited ResourceLimits if lower or equal to zero

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #20722: Apply rev suggestions

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #20722: Include check in previous tests

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #20722: Fix test typo

Signed-off-by: JesusPoderoso <[email protected]>

---------

Signed-off-by: JesusPoderoso <[email protected]>
(cherry picked from commit 31b8ad1)

# Conflicts:
#	include/fastdds/dds/core/policy/QosPolicies.hpp
#	test/unittest/dds/publisher/DataWriterTests.cpp
#	test/unittest/dds/subscriber/DataReaderTests.cpp
#	test/unittest/dds/topic/TopicTests.cpp
mergify bot pushed a commit that referenced this pull request Apr 4, 2024
@JesusPoderoso @mergify
Force unlimited ResourceLimits if lower or equal to zero (#4617)
3b04d8e 
* Refs #20638: Force unlimited ResourceLimits if lower or equal to zero

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #20722: Apply rev suggestions

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #20722: Include check in previous tests

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #20722: Fix test typo

Signed-off-by: JesusPoderoso <[email protected]>

---------

Signed-off-by: JesusPoderoso <[email protected]>
(cherry picked from commit 31b8ad1)
mergify bot pushed a commit that referenced this pull request Apr 4, 2024
@JesusPoderoso @mergify
Force unlimited ResourceLimits if lower or equal to zero (#4617)
35280a9 
* Refs #20638: Force unlimited ResourceLimits if lower or equal to zero

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #20722: Apply rev suggestions

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #20722: Include check in previous tests

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #20722: Fix test typo

Signed-off-by: JesusPoderoso <[email protected]>

---------

Signed-off-by: JesusPoderoso <[email protected]>
(cherry picked from commit 31b8ad1)
This was referenced Apr 4, 2024
Merged
Merged
Closed
Merged
Merged
Closed
JesusPoderoso added a commit that referenced this pull request Apr 10, 2024
@JesusPoderoso
Force unlimited ResourceLimits if lower or equal to zero (#4617)
77fad83 
* Refs #20638: Force unlimited ResourceLimits if lower or equal to zero

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #20722: Apply rev suggestions

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #20722: Include check in previous tests

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #20722: Fix test typo

Signed-off-by: JesusPoderoso <[email protected]>

---------

Signed-off-by: JesusPoderoso <[email protected]>
(cherry picked from commit 31b8ad1)
JesusPoderoso added a commit that referenced this pull request Apr 10, 2024
@JesusPoderoso
Force unlimited ResourceLimits if lower or equal to zero (#4617)
00f63fa 
* Refs #20638: Force unlimited ResourceLimits if lower or equal to zero

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #20722: Apply rev suggestions

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #20722: Include check in previous tests

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #20722: Fix test typo

Signed-off-by: JesusPoderoso <[email protected]>

---------

Signed-off-by: JesusPoderoso <[email protected]>
(cherry picked from commit 31b8ad1)
EduPonz pushed a commit that referenced this pull request Apr 17, 2024
@mergify @JesusPoderoso
Force unlimited ResourceLimits if lower or equal to zero (#4617) (#4652)
6e73bbe 
* Refs #20638: Force unlimited ResourceLimits if lower or equal to zero

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #20722: Apply rev suggestions

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #20722: Include check in previous tests

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #20722: Fix test typo

Signed-off-by: JesusPoderoso <[email protected]>

---------

Signed-off-by: JesusPoderoso <[email protected]>
(cherry picked from commit 31b8ad1)

Co-authored-by: Jesús Poderoso <[email protected]>
MiguelCompany pushed a commit that referenced this pull request Apr 17, 2024
@mergify @JesusPoderoso
Force unlimited ResourceLimits if lower or equal to zero (#4617) (#4653)
04b35db 
* Refs #20638: Force unlimited ResourceLimits if lower or equal to zero

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #20722: Apply rev suggestions

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #20722: Include check in previous tests

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #20722: Fix test typo

Signed-off-by: JesusPoderoso <[email protected]>

---------

Signed-off-by: JesusPoderoso <[email protected]>
(cherry picked from commit 31b8ad1)

Co-authored-by: Jesús Poderoso <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EduPonz EduPonz EduPonz approved these changes

Assignees

@JesusPoderoso JesusPoderoso

Labels
None yet
Projects
None yet
Milestone
v2.14.1
Development

Successfully merging this pull request may close these issues.

Allow inconsistent about DurabilityService QoS
2 participants
@JesusPoderoso @EduPonz