-
Notifications
You must be signed in to change notification settings - Fork 783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[20722] Force unlimited ResourceLimits if lower or equal to zero (backport #4617) #4654
Conversation
Cherry-pick of 31b8ad1 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
@JesusPoderoso would you mind addressing the conflicts here ? |
73e2b14
to
77fad83
Compare
* Refs #20638: Force unlimited ResourceLimits if lower or equal to zero Signed-off-by: JesusPoderoso <[email protected]> * Refs #20722: Apply rev suggestions Signed-off-by: JesusPoderoso <[email protected]> * Refs #20722: Include check in previous tests Signed-off-by: JesusPoderoso <[email protected]> * Refs #20722: Fix test typo Signed-off-by: JesusPoderoso <[email protected]> --------- Signed-off-by: JesusPoderoso <[email protected]> (cherry picked from commit 31b8ad1)
77fad83
to
00f63fa
Compare
@richiprosima please test this |
@JesusPoderoso we may take a look at this since the following tests have consistently failed |
These tests fail because #2807 was not backported. Consequently, in |
As this PR implies cherry-picking a prior PR that imposes a change of behavior, we finally decided not to go ahead with none of them. |
Description
This PR forces the ResourceLimitsQoS values (
max_samples
,max_instances
andmax_samples_per_instance
) to be considered as unlimited if a value greater than zero is NOT provided.@Mergifyio backport 2.13.x 2.10.x 2.6.x
Fixes #4609
Contributor Checklist
versions.md
file (if applicable).Related documentation PR: [20722] Update docs to force unlimited ResourceLimits if lower or equal to zero Fast-DDS-docs#738
Reviewer Checklist
This is an automatic backport of pull request #4617 done by [Mergify](https://mergify.com).