Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: set more scratch org props at creation #1000

Merged
merged 14 commits into from
Dec 5, 2023
Merged

feat: set more scratch org props at creation #1000

merged 14 commits into from
Dec 5, 2023

Conversation

mshanemc
Copy link
Contributor

What does this PR do?

  1. set the isScratch/isSandox/Namespace Org props during scratch org creation, along with snapshot being omitted if null.
  2. only query the server for orgs with those props missing--current code was querying in the case of false

What issues does this PR fix or reference?

kinda found this doing @W-14542428@

@mshanemc mshanemc changed the title Sm/set-scratchiness-during-creation feat: set more scratch org props at creation Nov 27, 2023
@mshanemc mshanemc requested a review from a team as a code owner December 4, 2023 14:50
@mshanemc mshanemc mentioned this pull request Dec 4, 2023
Merged
shetzel
shetzel previously approved these changes Dec 4, 2023
View reviewed changes
@shetzel shetzel merged commit 0d18e1f into main Dec 5, 2023
66 checks passed
@shetzel shetzel deleted the sm/set-scratchiness-during-creation branch December 5, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shetzel shetzel shetzel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mshanemc @shetzel @svc-cli-bot