resources: new oom_score_adj field #23259
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkazmierczak
added
backport/ent/1.8.x+ent
tgross
previously approved these changes
Jun 7, 2024
.changelog/23259.txt
Outdated
Comment on lines
1
to
3
| ```release-note:improvement | ||
| resources: Added new oom_score_adj field | ||
| ``` |
There was a problem hiding this comment.
We haven't wired this up to the drivers yet, so if we merge this and end up shipping Nomad 1.8.1 before that work is complete, the changelog entry won't make much sense. Maybe we should hold off adding the changelog entry until all the components (and documentation!) are in place? That way we can safely ship this code in main without stressing about 1.8.1.
There was a problem hiding this comment.
i can also remove the backport labels for now.
pkazmierczak
removed
backport/ent/1.8.x+ent
This was referenced Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds anoom_score_adjfield to resources that only accepts positive values. A task can mark itself as more likely to be OOM killed, but not less likely.Relates to #11087
Update: After discussing this with @schmichael, we decided to put this PR on hold and implement the feature via driver config for now.