Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check for coinbase maturity #128

Merged
merged 8 commits into from
Sep 4, 2024
Merged

check for coinbase maturity #128

merged 8 commits into from
Sep 4, 2024

Conversation

mubarak23
Copy link
Contributor

@vercel Vercel
Copy link

vercel bot commented Sep 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
raito ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 4, 2024 8:14am

@mubarak23 mubarak23 marked this pull request as draft September 3, 2024 06:23
maciejka
maciejka requested changes Sep 3, 2024
View reviewed changes
src/validation/transaction.cairo Outdated Show resolved Hide resolved
@mubarak23 mubarak23 requested a review from maciejka September 3, 2024 10:07
maciejka
maciejka requested changes Sep 3, 2024
View reviewed changes
Copy link
Collaborator

@maciejka maciejka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@m-kus do we want to add is_coinbase to get_block.py script, or it will be superseded by your work on new testing infra?

src/validation/transaction.cairo Outdated Show resolved Hide resolved
@mubarak23 mubarak23 requested a review from maciejka September 3, 2024 11:52
@mubarak23
Copy link
Contributor Author

mubarak23 commented Sep 3, 2024 •
edited
Loading

@m-kus can you pull this branch and run

scarb run get_blocks

my python setup is having conflict with
import requests and

import progressbar

@maciejka maciejka marked this pull request as ready for review September 3, 2024 14:44
m-kus
m-kus reviewed Sep 3, 2024
View reviewed changes
scripts/data/get_block.py Outdated Show resolved Hide resolved
@maciejka maciejka requested a review from m-kus September 3, 2024 16:35
@mubarak23 mubarak23 requested a review from m-kus September 3, 2024 17:06
@maciejka maciejka merged commit afd356c into keep-starknet-strange:main Sep 4, 2024
5 checks passed
mubarak23 added a commit to mubarak23/raito that referenced this pull request Sep 5, 2024
@mubarak23 @maciejka
check for coinbase maturity (keep-starknet-strange#128)
269d28a 
Co-authored-by: Maciej Kamiński <[email protected]>
od-hunter added a commit to od-hunter/raito that referenced this pull request Sep 6, 2024
@od-hunter
feat: impl validate BIP-34 sig script
8ad0574 
remove comment

check for coinbase maturity (keep-starknet-strange#128)

Co-authored-by: Maciej Kamiński <[email protected]>

fix: implement requested changes

fix: Impl the block height check and other reviewed changes

fix: Impl requested changes

fix: impl requested changes

fix: Impl requested changes

fix: Impl requested changes
This was referenced Sep 26, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-kus m-kus m-kus left review comments

@maciejka maciejka maciejka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mubarak23 @maciejka @m-kus