-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EVM] Add bridging interface to EVM contract #5677
Conversation
Nice work! BTW, I only suggested to have this on master and not only on the Cadence 1.0 feature branch, so the EVM code in the branches is the same, besides Cadence 1.0 compatibility |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work 👏
Thank you @ramtinms! FYI I added an event and setter in 78efce2 based on feedback from you and @janezpodhostnik. I don't believe we can emit events in interfaces pre-1.0, but I plan on emitting |
CI fails because test is already broken on master currently |
Is this an action item for this PR or just a statement saying this is ready for merge? |
A test on master is currently broken, so all PRs against master fail too. Once master is fixed, master should be merged into this PR, and then it can be merged once all tests pass. |
@turbolent thanks for the guidance, master has been merged and it looks like CI is now passing. |
Related: #5663
Adds pre-1.0 bridging interfaces to EVM contract as suggested by @turbolent in #5664
It looks like a number of tests are still failing, though I can't get to the bottom of why. In particular,
fvm_test.TestEVM
cases appear to be failing on failed contract declaration even though this PR includes updates to alias NFT & FT contracts.