Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated python version requested from the ci #967

Merged
merged 3 commits into from
Aug 3, 2023

Conversation

Iximiel
Copy link
Member

@Iximiel Iximiel commented Aug 2, 2023

Description

Python 3.7 has finally come to its EOL,I'm starting a series of PR for trying to see if python 3.9 can be used without to many modifications

Copyright
  • I agree to transfer the copyright of the code I have written to the PLUMED developers or to the author of the code I am modifying.
  • the module I added or modified contains a COPYRIGHT file with the correct license information. Code should be released under an open source license. I also used the command cd src && ./header.sh mymodulename in order to make sure the headers of the module are correct.
Tests
  • I added a new regtest or modified an existing regtest to validate my changes.
  • I verified that all regtests are passed successfully on GitHub Actions.

@GiovanniBussi
Copy link
Member

Great!

Looks like with centos 7 this is not trivial.

However, I checked a previously running job and it looks like the breaking change was the switch to cython 3.0.

Maybe it's sufficient to specify cython<3 here?

@GiovanniBussi GiovanniBussi mentioned this pull request Aug 2, 2023
@Iximiel
Copy link
Member Author

Iximiel commented Aug 2, 2023

Maybe it's sufficient to specify cython<3 here?

If it works I think it can be safely merged into 2.9 and then we should carefully update the master, because of the change in the CI

@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.04% ⚠️

Comparison is base (0493ec1) 85.91% compared to head (0a6ce2b) 85.88%.

❗ Current head 0a6ce2b differs from pull request most recent head 163da37. Consider uploading reports for the commit 163da37 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             v2.8     #967      +/-   ##
==========================================
- Coverage   85.91%   85.88%   -0.04%     
==========================================
  Files         595      595              
  Lines       49731    49731              
==========================================
- Hits        42724    42709      -15     
- Misses       7007     7022      +15     

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GiovanniBussi GiovanniBussi self-assigned this Aug 3, 2023
@GiovanniBussi GiovanniBussi merged commit 163da37 into plumed:v2.8 Aug 3, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants