Handle hardware errors in Resource Manager #805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
requested review from
bmagyar,
mhubii,
peterdavidfagan,
rosterloh,
Serafadam and
VX792
bmagyar
requested changes
Sep 4, 2022
hardware_interface/include/hardware_interface/resource_manager.hpp
Outdated
Show resolved
Hide resolved
| for (const auto & interface : hardware_info_map_[hardware_name].command_interfaces) | ||
| { | ||
| auto found_it = std::find( | ||
| available_command_interfaces_.begin(), available_command_interfaces_.end(), interface); |
There was a problem hiding this comment.
this is a search in a for loop... could this be implemented somehow using a more flat mapping by any chance? please feel free to say that I'm asking for impossible or very tedious things
There was a problem hiding this comment.
I will check this after I address above two comments that could also influence this.
| for (const auto & interface : hardware_info_map_[hardware_name].state_interfaces) | ||
| { | ||
| auto found_it = std::find( | ||
| available_state_interfaces_.begin(), available_state_interfaces_.end(), interface); |
There was a problem hiding this comment.
same search-in-a-for-loop situation
bmagyar
reviewed
Sep 4, 2022
…o works but the tests are missing.
destogl
force-pushed
the
handle-hardware-error-in-resource-manager
branch
from
9781116 to
3a87e45
Compare
bmagyar
approved these changes
Sep 24, 2022
|
@Mergifyio backport humble |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Oct 15, 2022
* Add code for deactivating controller when hardware gets an error on read and write. (cherry picked from commit e748824)
flochre
pushed a commit
to flochre/ros2_control
that referenced
this pull request
Jul 5, 2023
* Add code for deactivating controller when hardware gets an error on read and write. (cherry picked from commit e748824)
destogl
added a commit
that referenced
this pull request
Aug 9, 2023
* Add code for deactivating controller when hardware gets an error on read and write. (cherry picked from commit e748824)
destogl
added a commit
that referenced
this pull request
Dec 10, 2023
Co-authored-by: Denis Štogl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First part of the #742 with changes only in Resource Manager.