Fix parallel gripper controller CI #1202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
bmagyar,
DasRoteSkelett,
destogl,
livanov93,
mcbed,
moriarty and
VX792
|
This is very weird that the CI is failing for some node_name stuff. I've tested it locally on my rolling docker in a separate workspace it is building and the tests are passing successfully. Could this be the cache of CI @christophfroehlich? Moreover, if I remember correctly the CI on #1192 was successful right?. Can anyone with enough powers trigger the CI again? |
|
🚨 False alarm. After talking to @christophfroehlich it's just some pending releases and other issues we have caused it, so the CI is good. Thank you :) |
christophfroehlich
approved these changes
Jul 12, 2024
Yup! me neither. I don't know how it worked and ran tests till now XD |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a pre-formatting fix and also the failing build in the CI reported by @bmagyar and this is due to the recent change in the API of ros2_control
https://build.ros2.org/job/Jdev__ros2_controllers__ubuntu_noble_amd64/26/