Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit cast to period.count() #1404

Merged
merged 1 commit into from
Dec 1, 2024
Merged

Conversation

christophfroehlich
Copy link
Contributor

period.count() does not return an integer.
Fails with changes from ros-controls/control_toolbox#239 otherwise.

@christophfroehlich christophfroehlich added the backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS2 humble. label Dec 1, 2024
@christophfroehlich christophfroehlich changed the title Add explicit cast Add explicit cast to period.count() Dec 1, 2024
@christophfroehlich christophfroehlich merged commit 36068e1 into master Dec 1, 2024
17 of 19 checks passed
@christophfroehlich christophfroehlich deleted the fix/implicit_cast branch December 1, 2024 22:02
mergify bot pushed a commit that referenced this pull request Dec 1, 2024
christophfroehlich added a commit that referenced this pull request Dec 1, 2024
(cherry picked from commit 36068e1)

Co-authored-by: Christoph Fröhlich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS2 humble.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants