Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the .hpp headers from realtime_tools package #1406

Conversation

saikishor
Copy link
Member

@christophfroehlich mentioned about the update here : ros-controls/realtime_tools#206 (comment)

This PR addressed the same

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although this is not your first issue ;)

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.58%. Comparing base (36068e1) to head (cb88886).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1406      +/-   ##
==========================================
+ Coverage   83.56%   83.58%   +0.02%     
==========================================
  Files         122      122              
  Lines       10992    10989       -3     
  Branches      937      934       -3     
==========================================
  Hits         9185     9185              
  Misses       1493     1493              
+ Partials      314      311       -3     
Flag Coverage Δ
unittests 83.58% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...de/diff_drive_controller/diff_drive_controller.hpp 100.00% <ø> (ø)
...rd_command_controller/forward_controllers_base.hpp 100.00% <ø> (ø)
...jectory_controller/joint_trajectory_controller.hpp 100.00% <ø> (ø)
...ller/include/mecanum_drive_controller/odometry.hpp 100.00% <ø> (ø)
...nclude/tricycle_controller/tricycle_controller.hpp 100.00% <ø> (ø)

... and 3 files with indirect coverage changes

Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oi!

@bmagyar bmagyar merged commit cd73055 into ros-controls:master Dec 4, 2024
14 of 20 checks passed
@saikishor saikishor deleted the update/realtime_tools/headers branch December 5, 2024 10:56
@christophfroehlich
Copy link
Contributor

@Mergifyio backport humble

Copy link
Contributor

mergify bot commented Dec 16, 2024

backport humble

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Dec 16, 2024
(cherry picked from commit cd73055)

# Conflicts:
#	diff_drive_controller/include/diff_drive_controller/diff_drive_controller.hpp
#	joint_state_broadcaster/include/joint_state_broadcaster/joint_state_broadcaster.hpp
#	mecanum_drive_controller/include/mecanum_drive_controller/mecanum_drive_controller.hpp
#	mecanum_drive_controller/include/mecanum_drive_controller/odometry.hpp
#	parallel_gripper_controller/include/parallel_gripper_controller/parallel_gripper_action_controller.hpp
#	steering_controllers_library/include/steering_controllers_library/steering_controllers_library.hpp
#	tricycle_controller/include/tricycle_controller/tricycle_controller.hpp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants