-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JTC] Continue with last trajectory-point on success #842
Merged
bmagyar
merged 5 commits into
ros-controls:master
from
christophfroehlich:jtc/continue_success
Dec 1, 2023
Merged
[JTC] Continue with last trajectory-point on success #842
bmagyar
merged 5 commits into
ros-controls:master
from
christophfroehlich:jtc/continue_success
Dec 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
arne48,
bmagyar,
DasRoteSkelett,
destogl,
malapatiravi and
VX792
November 16, 2023 23:55
christophfroehlich
force-pushed
the
jtc/continue_success
branch
from
November 16, 2023 23:56
8ab7dbe
to
1b0d1af
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #842 +/- ##
==========================================
- Coverage 47.22% 46.77% -0.45%
==========================================
Files 40 40
Lines 3636 3641 +5
Branches 1716 1719 +3
==========================================
- Hits 1717 1703 -14
- Misses 735 749 +14
- Partials 1184 1189 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
christophfroehlich
force-pushed
the
jtc/continue_success
branch
from
November 19, 2023 21:26
129de58
to
21b7eef
Compare
christophfroehlich
force-pushed
the
jtc/continue_success
branch
from
November 28, 2023 10:12
f46b989
to
8b0e71e
Compare
christophfroehlich
force-pushed
the
jtc/continue_success
branch
from
December 1, 2023 08:09
8b0e71e
to
5d8142f
Compare
bmagyar
approved these changes
Dec 1, 2023
mergify bot
pushed a commit
that referenced
this pull request
Dec 1, 2023
(cherry picked from commit e4f1700)
christophfroehlich
added a commit
to christophfroehlich/ros2_controllers
that referenced
this pull request
Dec 1, 2023
christophfroehlich
added a commit
that referenced
this pull request
Dec 4, 2023
(cherry picked from commit e4f1700)
christophfroehlich
added a commit
that referenced
this pull request
Dec 5, 2023
(cherry picked from commit e4f1700)
christophfroehlich
added a commit
that referenced
this pull request
Dec 5, 2023
(cherry picked from commit e4f1700)
christophfroehlich
added a commit
to christophfroehlich/ros2_controllers
that referenced
this pull request
Dec 5, 2023
bmagyar
pushed a commit
that referenced
this pull request
Dec 6, 2023
christophfroehlich
added a commit
that referenced
this pull request
Dec 9, 2023
(cherry picked from commit e4f1700)
christophfroehlich
added a commit
that referenced
this pull request
Jan 2, 2024
(cherry picked from commit e4f1700)
christophfroehlich
added a commit
that referenced
this pull request
Jan 12, 2024
(cherry picked from commit e4f1700)
christophfroehlich
added a commit
that referenced
this pull request
Feb 17, 2024
(cherry picked from commit e4f1700)
christophfroehlich
added a commit
that referenced
this pull request
Mar 6, 2024
(cherry picked from commit e4f1700)
bmagyar
pushed a commit
that referenced
this pull request
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #811: Continue with last trajectory point on success, instead of hold-position from current state.
Closes #811 and closes #759.